Giter VIP home page Giter VIP logo

Comments (3)

sobolevn avatar sobolevn commented on May 20, 2024 1

Anyway, this does not remove my consideration about consciously rising an exception here.
I use both versions with 50/50 rate.

@vergeev I guess that you are talking about beginners, who make this error and crush their programs. But, that's not the case here.

Thanks for your suggestion, but I am going to reject it.
Please, open new ones if you have any. I appreciate your attitude towards this project.

Cheers. 👍

from wemake-python-styleguide.

sobolevn avatar sobolevn commented on May 20, 2024

But what if we have the following function:

def fetch_property(obj, key_name):
     return getattr(obj, key_name)

And I want to throw an exception here! Because I prefer an exception over None.
You solution implies that we will have to manually raise these exceptions:

foobar = getattr(x, 'foobar', None)
if foobar is None:
    raise AttributeError()

from wemake-python-styleguide.

vergeev avatar vergeev commented on May 20, 2024

Good catch! What I actually meant is prohibit the case in which the second argument is a string literal (which is always something constant).

I've updated the issue.

from wemake-python-styleguide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.