Reimplement tiling options in the storyscreen about wesnoth HOT 9 CLOSED

I'd like to look into this bug, but from your description i have no idea what the problem is. Could you please elaborate?

from wesnoth.

See the wiki for reference. There are several keys described there (under [background_layer]) that specify scaling and tiling options. These no longer function as advertised.

Since the new storyscreen is GUI2, this will require an expansion of the supported scaling and tiling options in the GUI2 canvas. I think the functions to do the actual work should be already implemented, so you just need to figure out when and where to call them, hopefully.

from wesnoth.

Partially re-implemented in 4f79fed, but unless someone wants to modify the widgets, the WML interface should probably be changed.

from wesnoth.

So that's partial because it only supports the case where horizontal and vertical are set to the same value, I guess? Full support would require alteration of the GUI2 canvas WML as well.

from wesnoth.

Where the hell even is that commit? I can't find it.

from wesnoth.

Anyway, fully implemented above.

from wesnoth.

Nice! Does that finally cover everything, then? It'd be nice to expand the test added by @AI0867 so that it covers more cases, too.

I'm kinda surprised (and slightly suspicious) that this seems to have been done without touching the GUI2 canvas code at all...

from wesnoth.

As that commit was on a branch on my own fork, it was not actually 'added'. I've now added the testcase in 39c3f21.

from wesnoth.

Ah, okay. I guess that explains why vultraz couldn't find it... >_>

from wesnoth.