Modified on 2007-08-29 anonymous wrote:</st

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Pinging <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-

Show the weapon tooltip in recruit/recall dialogs too (GNA #3698) about wesnoth HOT 10 OPEN

wesnoth commented on April 28, 2024

Show the weapon tooltip in recruit/recall dialogs too (GNA #3698)

from wesnoth.

Comments (10)

Wedge009 commented on April 28, 2024 1

I think this needs to be factored out:

wesnoth/src/reports.cpp

Lines 866 to 902 in e235d9a

 tooltip << _("Weapon range: ") << "<b>" << range << "</b>\n" 

 << _("Damage type: ") << "<b>" << lang_type << "</b>\n" 

 << _("Damage versus: ") << '\n'; 

 // Show this weapon damage and resistance against all the different units. 

 // We want weak resistances (= good damage) first. 

 std::map<int, std::set<std::string>, std::greater<int>> resistances; 

 std::set<std::string> seen_types; 

 const team &unit_team = rc.dc().get_team(u.side()); 

 const team &viewing_team = rc.teams()[rc.screen().viewing_team()]; 

 for (const unit &enemy : rc.units()) 

 { 

 if (enemy.incapacitated()) //we can't attack statues so don't display them in this tooltip 

 continue; 

 if (!unit_team.is_enemy(enemy.side())) 

 continue; 

 const map_location &loc = enemy.get_location(); 

 const bool see_all = game_config::debug || rc.screen().show_everything(); 

 if (!enemy.is_visible_to_team(viewing_team, see_all)) 

 continue; 

 bool new_type = seen_types.insert(enemy.type_id()).second; 

 if (new_type) { 

 int resistance = enemy.resistance_against(at, false, loc); 

 resistances[resistance].insert(enemy.type_name()); 

 } 

 } 

 for (const auto& resist : resistances) { 

 int damage_with_resistance = round_damage(specials_damage, damage_multiplier * resist.first, damage_divisor); 

 tooltip << "<b>" << damage_with_resistance << "</b> " 

 << "<span color='" << attack_info_percent_color(resist.first-100).to_hex_string() << "'>" 

 << "<i>(" << utils::signed_percent(resist.first-100) << ")</i>" 

 << naps 

 << " : \t" // spaces to align the tab to a multiple of 8 

 << utils::join(resist.second, " " + font::unicode_bullet + " ") << '\n'; 

 } 

 const string_with_tooltip damage_versus {flush(str), flush(tooltip)};

...so it can be re-used here (called by both unit recruit and recall dialogues):

wesnoth/src/gui/widgets/unit_preview_pane.cpp

Lines 222 to 257 in e235d9a

 const std::string range_png = std::string("icons/profiles/") + a.range() + "_attack.png~SCALE_INTO_SHARP(16,16)"; 

 const std::string type_png = std::string("icons/profiles/") + a.type() + ".png~SCALE_INTO_SHARP(16,16)"; 

 const bool range_png_exists = ::image::locator(range_png).file_exists(); 

 const bool type_png_exists = ::image::locator(type_png).file_exists(); 

 const t_string& range = string_table["range_" + a.range()]; 

 const t_string& type = string_table["type_" + a.type()]; 

 const std::string label = (formatter() 

 << font::span_color(font::unit_type_color) 

 << a.damage() << font::weapon_numbers_sep << a.num_attacks() 

 << " " << a.name() << "</span>").str(); 

 auto& subsection = header_node.add_child( 

 "item_image", 

 { 

 { "image_range", { { "label", range_png } } }, 

 { "image_type", { { "label", type_png } } }, 

 { "name", { { "label", label }, { "use_markup", "true" } } }, 

 } 

 ); 

 find_widget<styled_widget>(&subsection, "image_range", true).set_tooltip(range); 

 find_widget<styled_widget>(&subsection, "image_type", true).set_tooltip(type); 

 if(!range_png_exists || !type_png_exists) { 

 add_name_tree_node( 

 subsection, 

 "item", 

 (formatter() 

 << font::span_color(font::weapon_details_color) 

 << range << font::weapon_details_sep 

 << type << "</span>" 

 ).str() 

 ); 

 }

But I don't know if they are even compatible (eg GUI1 vs GUI2). I recall the unit preview pane is a much newer development compared with the unit details given in the side-bar (especially with the nice little icons for alignment, race, weapon range and attack type).

from wesnoth.