Disabling Log File button when not using a log file about wesnoth HOT 12 CLOSED

The paths are collated into a map and added to the dialogue one at a time, with accompanying open and copy buttons. I suppose one could check that the paths are valid and disable the open button in the cases where it is not.

from wesnoth.

It looks like this is not an issue in Windows because a default logs directory gets created if one doesn't already exist.

Edit: I'm not able to replicate this. If I remove the logs directory, it triggers the migration dialogue and part of that process seems to recreate the logs directory.

from wesnoth.

It is about using the command line option --no-log-to-file

from wesnoth.

Yes, I know. Even using --no-log-to-file, the logs directory still gets recreated for me. BTW, you didn't specify which version - I was testing official 1.18.0 release and self-compiled 1.18 branch, though I presume master/1.19.0+dev would behave the same way.

from wesnoth.

Can anyone replicate the underlying bug for this request and specify the details, please?

from wesnoth.

I mean that it should not offer the button at all. The button is for opening the log file, and as it is specified on command line to not use a log file, there cannot be a correct path. It does not matter whether the logs directory exists. If it exists, then there is no file to open (and should not be).

I use a self-compiled 1.18.0, though with current 1.18 branch.

from wesnoth.

Again, I understand that - on my system when I specify the console to be used for logging via --no-log-to-file the logs directory is always created. Therefore, I cannot replicate the scenario you had in the original report.

As for the idea that the option to open the normal logs directory should not be available if logging to file is disabled, I don't necessarily agree with that. Even though I normally disable logging to file on Linux, I still have some logs available there and I don't think it's harmful or even makes sense to disable the option to open an existing logs directory, even if it's empty.

from wesnoth.

I think there is a misunderstanding about what is meant. I think sevu means the log file button on the lower left of the dialog. Not the button to open the log dir.

from wesnoth.

I ran Wesnoth with --no-log-to-file. The bottom-left icon just copies a report into a buffer and I can paste this text as normal. I do not think disabling logging should affect this in any way.

Since the logs directory gets recreated, I cannot replicate the error in the original report, no matter what button I try.

from wesnoth.

In your screenshot the button in question is the one saying "Fichier de journalisation". The one that explains it opens the current log file in the tool tip.

When I press that button in the flatpak build I get the error Failed to open '/home/wesnoth/.log': No such file or directory.

from wesnoth.

Okay, I feel pretty silly now, seeing it stare at me in the face. I've never used that button before, I've always just gone straight to the logs directory myself.

Strangely, in both Windows and Linux (specifically, KDE/X11), when using --no-log-to-file, I still can't replicate either of your errors. Instead, no action occurs when the log file button is clicked - error messages go to the log console rather than shown in a separate dialogue. Nonetheless, I agree that the button should be disabled with the no-log-file option - while no action is better than the error messages you're reporting, it's still a problem.

from wesnoth.

So the relevant code is here:

Looks like it should be checking for the existence of the file at log_path_, not just that the string is non-empty.

from wesnoth.