Class invariants of attack_type and attack_type::specials_context_t about wesnoth HOT 3 OPEN

adding the insertions doesn't change anything, infinite recursion still happens.

from wesnoth.

The plan for fixing the infinite recursion would be either

• track the depth of the filters (how many times they've recursed, without considering why), or
• track all the current-unresolved checks to see if the latest depth of recursion duplicates an already-open check

This issue is a step along the route to that, looking at where the bookkeeping data could go, and finding that there's an issue to address before looking at the recursion itself.

from wesnoth.

Imo it does make sense, to move these parts out of the attack_type class, and have a abilities_context class instead, i actually wanted to do something like that when i worked on #7589, but didnt find the time to do it.

But iirc my plan was to:

1. have an abilities_context class with members, first_unit, first_unit_loc, first_unit_weapon, second_unit, second_unit_loc, second_unit_weapon
2. move most of the function that are currently in abilties.cpp there
3. Let it keep track of which abilities have already been checked for that case so that we don't unneccecarily evaulate things twice,

from wesnoth.