wetransfer / concorde.js Goto Github PK

Describe the bug

Currently when you use the Cookie module and try to set a cookie with days parameter it must be an Integer, not a decimal. If it is a decimal it fails silently and defaults to session length.

To Reproduce

Steps to reproduce the behavior:

1. Require the Cookie module
2. Call the cookie set function with some dummy data and a decimal days parameter:
   Cookie.set('test', 'test', { days: 10.5 });
3. Check that the cookie length time defaults to session time on your browser cookie panel.

Expected behavior

Alert the user that decimals can't be used or round the number up or down instead of defaulting to session length

Additional context

Related issues:

• https://github.com/WeTransfer/frontend/pull/11168

The creation process of new modules is manual right now, and it implies copy&paste an existing module, modify names, update docs, etc. This is error prone and far from being performant.

Something like Yeoman generators, using EJS

We export our modules as a single UMD, which works just fine, but adds an extra boilerplate and makes it complicated to perform some tree shaking with webpack or rollup.

Including the original ES6 source code and adding the module property to our package.json files should do the trick: https://github.com/dherman/defense-of-dot-js/blob/master/proposal.md#typical-usage

We need to update our main README file to include the following info:

• Features
• Requirements
• Usage
• Communication
• Installation
• Release Notes
• License

And also add a Code of conduct and contributing guidelines based on other OS projects at WeTransfer.

As per npm documentation:

The “author” is one person. “contributors” is an array of people.

We are specifying "author": "WeTransfer folks",, which is not correct. We also may want to add ourselves as contributors, or add a generic dev account, like "contributors": ["WeTransfer folks <[email protected]> (https://github.com/WeTransfer)"]

prepublish task is not running before we publish the code to npm, therefore, the packages are broken right now.