Giter VIP home page Giter VIP logo

Comments (4)

domenic avatar domenic commented on July 18, 2024

Compatibility uses compatibility.bs while its shortname is compat.

We could rename it. If we do it in a single commit history will still be there in Git, although it looks like the GitHub UI does not follow renames :(. So, maybe not worth it... I guess we could hard-code an exception into the tool, if we anticipate this being a long-term issue.

Console: Different .editorconfig (indent_size = 2 rather than 1)

We should fix the editorconfig and the spec to align.

Console: Different .gitignore

This seems to be due to the test/ and reference-implementation/ subdirectories. However those have not been maintained, so we should just remove it. See also whatwg/console#152.

The other divergences can be removed.

Console: Has no .pr-preview.json

We should fix

Console: Custom Makefile (does not seem to be needed other than EXTRA_FILES though)

We should align it. Although, we could copy some of its additions, which are reasonable practice:

SHELL=/bin/bash -o pipefail
.PHONY: local remote deploy review

(See here for the .PHONY business.)

HTML: Weird that it has indent_size = 2 and no max_line_length = 100.

Oh wow, that's why my editor keeps resetting to indent_size 2!

Streams

I would like to remove Node from the build process at some point, and align on indent/line length.

from spec-factory.

annevk avatar annevk commented on July 18, 2024

It now works for everything except HTML and Streams. I'll still PR Streams with some local tweaks as overall it's an improvement there too.

from spec-factory.

annevk avatar annevk commented on July 18, 2024

a10cf79 excludes HTML/Streams. I suspect Streams can soon be enabled again and for HTML we probably want to to update a subset of files only.

from spec-factory.

annevk avatar annevk commented on July 18, 2024

Streams was fixed in #15.

from spec-factory.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.