Comments (14)
I guess it's too late to stop doing that?
@asutherland @mkruisselbrink @jakearchibald
from xhr.
"that" being exposing FileReader to service workers? Now all major browsers have implemented Blob.stream/text/arrayBuffer there at least is an alternative to FileReader (other than wrapping a Blob in a Response). My gut feeling is that actually removing FileReader from service workers would be challenging though.
from xhr.
Yeah, removing FileReader
. If it's too late I support doing this.
from xhr.
Hey!!
Are you willing to accept new contributors? I am interested into contributing to this repository so, if you could explain a bit more this feature request, it would be great.
Thanks
from xhr.
Lines 1764 to 1765 in b7726ee
Currently the line 1764 lacks ServiceWorker
, so we need to add one. I don't think we need anything other than that 👍
from xhr.
Hey!! I wanna do that will you please assigned this issue to me that will be great .
from xhr.
I don't think assigning is used in this repo. Just open a PR and make sure you include Fixes #305
in the description 😉. It will automatically link your PR to this issue.
from xhr.
Thank You
@saschanaz
but what is fixed in Fixes #305.
If You don't mind Could You please explain little deeper.
from xhr.
Hmm, I mean when you open a pull request after writing the actual fix, you'll want to include the "Fixes" text to the content body of the post. It's not a requirement but just a recommendation, so if you have no idea please just proceed.
from xhr.
Understood...But no Description box is coming.
written -"there isn't nothing to compare"
How to do that?
from xhr.
You committed the fix and you see that message? Weird, could you share the screenshot?
from xhr.
Can we please start it again?
Excuse me!! But I just got confused...
How to add a service Worker? I did in my own way...which is not adjusting with the repo.
Please teach me a little more..
from xhr.
No problem! The easiest way:
- Open https://github.com/whatwg/xhr/blob/main/xhr.bs
- Click the edit button at the right side (which looks like a pen)
- Search
interface ProgressEvent
and add,ServiceWorker
to the previous line - At the "Propose changes" block, write a title e.g. "Expose ProgressEvent to ServiceWorker"
- Click "Propose changes" button.
- Cilck "Create pull request"
- Type "x" inside
[ ]
so that it can be[x]
, for "At least two implementers are interested" part, and replace "..." with "Gecko" and "WebKit". This is based on my observation in #305 (comment). (You can skip this.) - Cilck "Create pull request" again
- That's it!
I'll happily write steps for GitHub Desktop if you are using it BTW.
from xhr.
@saschanaz
Thank You so so much ..
I did that..
What next to do?
from xhr.
Related Issues (20)
- Handle error while reading response body in synchronous XHR HOT 1
- Reference primitive for "If one or more event listeners are registered"
- Spec requires firing at least two "progress" events; browsers do not. HOT 1
- features request:add SynXMLHttpRequest for Avoid Callback Hell Programming HOT 1
- Why do we need to remove synchronous XHR? HOT 2
- link error breaking deploys HOT 2
- Allow to send body within GET http requests HOT 1
- Aborted flag check in "handle errors" HOT 2
- interop: blob with empty content type is not converted to text/xml HOT 3
- Wrong upload progress when network interrupts HOT 3
- xmlhttprequest.responseText occasionally appears Chinese garbled characters HOT 1
- XHR: how can I read request headers? HOT 1
- Need Discussion of 'why' Behind Deprecation of sync xhr HOT 2
- Wrong algorithm + missing realm argument when creating ArrayBuffer
- Ambiguous definition/initial values of network error HOT 3
- Use HTML's parse a URL HOT 2
- FormData & submitter[formaction] HOT 6
- `FormData`: Accept `object` form in constructor HOT 1
- Clarify if `ProgressEvent.loaded` should indicate the size of compress, or uncompressed, data HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xhr.