Giter VIP home page Giter VIP logo

Comments (2)

rubdos avatar rubdos commented on June 26, 2024

We should probably start implementing the interface instead of just ignoring messages.

from libsignal-service-rs.

gferon avatar gferon commented on June 26, 2024

Note: basic support for making sure we have a PNI UUID is in place, but we currently hardcode the use of ServiceIdType::AccountIdentity in a bunch of helper methods like update_pre_key_bundle. Fully supporting PNI requires having two separate implementations of the ProtocolStore that end up storing a separate key-pair, sessions as well as pre-keys.

@rubdos I think a good way to do this would be to add our own ProtocolStore trait (or AccountStore?) that has two methods: aci_protocol_store and pni_protocol_store. That way, we could have functions only take a ServiceIdType as a parameter, and mimick what is done in Signal-Android. Design wise, we can really think of whatever works best (and helps us avoid adding more type parameters).

from libsignal-service-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.