Comments (2)
We should probably start implementing the interface instead of just ignoring messages.
from libsignal-service-rs.
Note: basic support for making sure we have a PNI UUID is in place, but we currently hardcode the use of ServiceIdType::AccountIdentity
in a bunch of helper methods like update_pre_key_bundle
. Fully supporting PNI requires having two separate implementations of the ProtocolStore
that end up storing a separate key-pair, sessions as well as pre-keys.
@rubdos I think a good way to do this would be to add our own ProtocolStore
trait (or AccountStore
?) that has two methods: aci_protocol_store
and pni_protocol_store
. That way, we could have functions only take a ServiceIdType
as a parameter, and mimick what is done in Signal-Android. Design wise, we can really think of whatever works best (and helps us avoid adding more type parameters).
from libsignal-service-rs.
Related Issues (20)
- Send message HTTP status 428 not handled
- Remove e164 / phone number from ServiceAddress
- Refactor/merge ServiceCipher::open_envelope and ServiceCipher::decrypt
- Support contact discovery HOT 2
- PlaintextContent not handled HOT 2
- serde_json fails parsing empty HTTP 200 response HOT 1
- Groups v2 getAuthorizationForToday stopped working HOT 2
- Not sending SyncMessage if only linked device HOT 4
- Rework the pre-key management
- Upgrade to libsignal v0.31 or later
- Trigger PreKey-fetching on SessionNotFound
- Add ability to set user-agent HOT 1
- Can't send messages
- Receiving messages failed due to: `SignalProtocolError(InvalidKyberPreKeyId)`
- `TryFrom<EnvelopeEntity> for Envelope` contains strange (and outdated?) logic
- Attachments are encrypted with synchronous code in the executor HOT 1
- JSON Invalid Padding
- MessageSender::send_contact_details seems to have some parameters too many
- Groups Fail with Newly Linked Devices
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libsignal-service-rs.