Giter VIP home page Giter VIP logo

Comments (10)

mmattosr avatar mmattosr commented on May 31, 2024 2

Actually its possible tu use this aproach: https://aws.amazon.com/pt/blogs/compute/authenticating-amazon-ecr-repositories-for-docker-cli-with-credential-helper/

I'll try to make a PR in my free time with this.

from docker-build-with-cache-action.

jbarop avatar jbarop commented on May 31, 2024 2

ecr get-login is deprecated and got replaced with ecr-get-login-password.

This works for me:

    - name: Configure AWS credentials
      uses: aws-actions/configure-aws-credentials@v4
      with:
        aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
        aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
        aws-region: your-region-1

    - name: Get AWS ECR credentials
      id: ecr-credentials
      run: |
        echo "::set-output name=username::AWS"
        echo "::set-output name=password::`aws ecr get-login-password`"

    - name: Docker build
      uses: whoan/docker-build-with-cache-action@master
      with:
        username: ${{ steps.ecr-credentials.outputs.username }}
        password: ${{ steps.ecr-credentials.outputs.password }}
        registry: ${{ secrets.AWS_ECR_REGISTRY }}
        image_name: some-image-name

from docker-build-with-cache-action.

whoan avatar whoan commented on May 31, 2024 1

Hi @viyullas . I didn't try with AWS, I thought you need aws-cli to login to registry so I didn't want to add more complexity to the script because of that. I can try at the weekend and let you know.

from docker-build-with-cache-action.

whoan avatar whoan commented on May 31, 2024 1

Yes, that was my guess, that you can't login to AWS ECR with docker login. For that reason, this action doe snot support to login to ECR for the moment.

Maybe in the future. I am glad you found that action to make it work. Thanks.

Closing this one.

from docker-build-with-cache-action.

viyullas avatar viyullas commented on May 31, 2024

There is an action to make the login (aws-actions/amazon-ecr-login@v1), but I could not manage to make it work even after executing this action.

from docker-build-with-cache-action.

whoan avatar whoan commented on May 31, 2024

Can you successfully docker login to AWS ECR from your console with those credentials? Just to discard any problem with the creds.

from docker-build-with-cache-action.

viyullas avatar viyullas commented on May 31, 2024

You don't "docker login" to ECR, you have to login using aws-cli and then you can interact with ECR again using aws-cli
I am using another action that seems to do the trick "devmasx/cached-docker-build-push"

from docker-build-with-cache-action.

whoan avatar whoan commented on May 31, 2024

@jbarop I added your comment to the readme. Thanks!
Closing this.

from docker-build-with-cache-action.

whoan avatar whoan commented on May 31, 2024

I think there should be an easier way. I am going to give a try whenever I have some free time. Feel free to work on it.

from docker-build-with-cache-action.

james-song avatar james-song commented on May 31, 2024

maybe, aws-actions/configure-aws-credentials@v4 is wrong

it should be aws-actions/configure-aws-credentials@v1

from docker-build-with-cache-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.