Giter VIP home page Giter VIP logo

Comments (7)

whoan avatar whoan commented on May 30, 2024 1

@arnav13081994 I thought about it and it would need many changes int he code, and as you can accomplish the same creating a step for each image you need to build based on the compose file, I decided it wasn't worth it.

I am not telling I can't change my mind in the future. I will leave this open just in case I have some free time to give it a try and to see if there are more people interested.

from docker-build-with-cache-action.

whoan avatar whoan commented on May 30, 2024 1

Hi @NasAmin . Thanks for your feedback.
I promise I will give another chance to this issue in my spare time and will let you know the outcome.

from docker-build-with-cache-action.

whoan avatar whoan commented on May 30, 2024 1

@NasAmin @arnav13081994 @helloguille You can test the branch support-compose-files to see if it works for you. I made this test and seems to work fine. I will wait for some feedback to merge and release a new version (probably v5.8.0)

from docker-build-with-cache-action.

arnav13081994 avatar arnav13081994 commented on May 30, 2024

@whoan Yes, you are right.

from docker-build-with-cache-action.

helloguille avatar helloguille commented on May 30, 2024

@whoan That sounds like a good option that would probably save a lot of headaches. Do you know if I build the images using this action separately, will this cache be used by docker compose afterwards?

from docker-build-with-cache-action.

whoan avatar whoan commented on May 30, 2024

I tried to think of the different use cases reading from a compose file and having multiple images hosted in different registries is not an easy scenario to handle without many changes in the script.

I still think that it's better to build individually and then the docker-compose build should take advantage of the cache created by the individual builds as long as you use the correct names in the compose file in subsequent steps of the same job (that is what happens if you build individually in your host and then run docker-compose build).

I will continue thinking on it though.

from docker-build-with-cache-action.

NasAmin avatar NasAmin commented on May 30, 2024

hmm, this Action rocks!
But we have a build script that uses docker-compose to build mutiple images. I used this action to build individual images but it results in:

  • Duplication of the config
  • passing multiple build args is a bit hard if you have a lot
  • You can't build locally the same way as you would in the CI pipeline. Our build script was designed so it would build and behave the same way no matter where it ran.

So the ability to run docker build or docker-compose would be amazing.

I also tried to use this action but it seems to make my builds even slower than if I don't use any cache at all.

I would appreciate if this is given some thought.

from docker-build-with-cache-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.