support aws-actions about docker-build-with-cache-action HOT 3 CLOSED

Is there any problem with current ecr login? You should be able to log in like this:

- uses: whoan/docker-build-with-cache-action@v5
  with:
    username: "${{ secrets.AWS_ACCESS_KEY_ID }}"
    password: "${{ secrets.AWS_SECRET_ACCESS_KEY }}"
    session:  "${{ secrets.AWS_SESSION_TOKEN }}"  # if you need role assumption
    registry: 861729690598.dkr.ecr.us-west-1.amazonaws.com
    image_name: hello-world

from docker-build-with-cache-action.

to be honest, I didn't try it because after reading the documentation I realized this wasn't going to do what I need, so it probably does work. The reason I opened this is because I need to login to AWS to access other services too, seems silly to login more than once. I'm also not certain how it might interact with those steps depending on what you're doing. ecr login also has an output that auto returns the registry name and sanitized the account id in login output. I think on step cleanup? hook aws credentials is removing the credentials.

from docker-build-with-cache-action.

@xenoterracide I think that we should only take advantage of the environment variables configure-aws-credentials set, but only to reuse AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY. Using the registry from the output makes docker-build-with-cache-action too dependent of the context IMO.

from docker-build-with-cache-action.