Jenkins Agents always install the latest docker instead of pinned version about aws-cf-templates HOT 4 CLOSED

I can't confirm, because I don't run the latest jenkins template, but a modified version of one some number of releases back. I did a review of your PR though and from a static analysis viewpoint it looks fine to me.

from aws-cf-templates.

I believe I found the problem. The issue was that the test for docker was failing because the section '[amzn2extra-docker]' was already in amzn2-extras.repo and was set to latest (a dependency of some prior tool? enabled by default? changed in some new version of amazon linux since the template was written?). So the test section fails and the command is never run. I removed the test line and added the yum clean metadata line to the command, and now version 18.06.1 is installed on the nodes. Here's a diff:

             'a_enable_docker':
-              command: 'amazon-linux-extras enable docker=18.06.1'
-              test: "! grep -Fxq '[amzn2extra-docker]' /etc/yum.repos.d/amzn2-extras.repo"
+              command: 'amazon-linux-extras enable docker=18.06.1; yum clean metadata'

It helped once I found that logs are in /var/log/cfn-init.log and I noticed this:

021-05-02 16:21:07,651 P3079 [INFO] Test for Command a_enable_docker
2021-05-02 16:21:07,654 P3079 [ERROR] Exited with error code 1
2021-05-02 16:21:07,655 P3079 [INFO] ============================================================
2021-05-02 16:21:07,655 P3079 [INFO] Test for Command b_enable_corretto8
2021-05-02 16:21:07,658 P3079 [INFO] Completed successfully.
2021-05-02 16:21:07,658 P3079 [INFO] ============================================================
2021-05-02 16:21:07,658 P3079 [INFO] Command b_enable_corretto8
2021-05-02 16:21:07,891 P3079 [INFO] -----------------------Command Output-----------------------
2021-05-02 16:21:07,891 P3079 [INFO]      0  ansible2                 available    \
2021-05-02 16:21:07,891 P3079 [INFO]            [ =2.4.2  =2.4.6  =2.8  =stable ]
...
2021-05-02 16:21:07,892 P3079 [INFO]     20  docker=latest            enabled      \
2021-05-02 16:21:07,892 P3079 [INFO]            [ =17.12.1  =18.03.1  =18.06.1  =18.09.9  =stable ]

NOTE: that for some reason 18.09.9 would not install for me because the source could not be found for some reason, so 18.06.1 is the most recent version of docker available using this method of installation. I would have liked to use 19.03.13ce-1 as well, but that is not a valid option for amazon-linux-extras. An alternative may be to use amazon-linux-extras enable docker and then add the version to the line where yum does the install, but unfortunately, I'm out of time for further exploration into this issue.

from aws-cf-templates.

Thanks for the bug report. I'm working on a fix.

from aws-cf-templates.

@timharsch could you confirm that the fix in #551 fixes your issue?

from aws-cf-templates.