Giter VIP home page Giter VIP logo

Comments (3)

art-in avatar art-in commented on June 11, 2024

ok, it's even worse.

first co2 reading after startup is 400.
so the sequence is like 400, 0, 0, ..., 0, 0, 620, 622, ...

init process got fooled with first reading, thinking it's warmed up but it's not.

but with TEMPUNLIM (getCO2(true, true)) first reading is zero.
sequence is 0, 0, ..., 0, 0, 620, 622, ...

unfortunately first reading is still not filtered, second and others until warmed up are filtered.

so im' currently using this workaround:

void init_mhz() {
  mhz_serial.begin(MHZ_BAUDRATE);

  mhz.begin(mhz_serial);
  mhz.setFilter(true, true);

  mhz.setRange(2000);
  mhz.autoCalibration(true);

  // warming up
  while (true) {
    int co2 = mhz.getCO2(true, true);

    if (mhz.errorCode == RESULT_FILTER) {
      log_ln("sensors: mhz: warming up...");
    } else if (mhz.errorCode != RESULT_OK) {
      log_ln("sensors: mhz: failed to read CO2 on warmup.", true);
    } else if (co2 == 0) {
      // TODO: remove when zero co2 is filtered
      // https://github.com/WifWaf/MH-Z19/issues/6
      log_ln("sensors: mhz: received zero, continuing warmup...", true);
    } else {
      // warmed up
      break;
    }

    delay(CO2_WARMING_READ_PERIOD);
  }
}

from mh-z19.

WifWaf avatar WifWaf commented on June 11, 2024

You can use setFilter(true, false) to return the offending values, but not set them to 0 - is this what you are looking for? You can then check the RESULT_FILTER code, and choose to ignore the value or store for verification.

The setFilter(true, true) will set the CO2 values to 0 as you've shown. It allows a simple truthy/falsey check to be used.

The difference between TEMPLIM and TEMPULIM is that the first returns CO2 as per the datasheet command. That is, if your CO2 ppm drops below 400ppm, or exceeds your range, the values are capped, and will not show below/above these thresholds. TEMPULIM simply returns the CO2 ppm regardless is not capped, this command is not found in the datasheets - I should probably rename the enumerations as they are outdated.

I'm not sure why the TEMPLIM returns the 400ppm for the initial value, I'll have to test this... the filter was pretty awkward to setup.

from mh-z19.

WifWaf avatar WifWaf commented on June 11, 2024

Should be corrected now.

from mh-z19.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.