Comments (5)
Since Wikibase lets extensions define new datatypes, we should make sure that it is not necessary to modify Wikidata-Toolkit itself to use those datatypes.
As far as I know, it should already be possible for you to use Wikidata-Toolkit to work with EDTF values on a Wikibase instance.
Notice that the list of datatypes stored in DatatypeIdValue
is actually a list of static strings. That means that you can actually supply your own IRI for the EDTF datatype and instanciate a DatatypeIdValue with that (without making any change to Wikidata-Toolkit).
Also, retrieving values (via wbgetentities
) and editing them (via wbeditentity
or its friends) should already be supported because EDTF uses the string
datavalue type, which is already supported.
That being said, if you want to contribute a canonical IRI for the EDTF datatype and store it as a static string in Wikidata-Toolkit, I think that is totally fine.
from wikidata-toolkit.
Thanks for the quick reply. I didn't realize I could supply my own datatype IRI. It might still be good to add the canonical IRI "http://wikiba.se/ontology#Edtf" (according to https://github.com/Wikidata/triplify-json), but I'll leave the conversion and stuff out then.
from wikidata-toolkit.
Aw no push permission..
from wikidata-toolkit.
The way it works in GitHub is that you need to create a "pull request":
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request
from wikidata-toolkit.
Done: #701
from wikidata-toolkit.
Related Issues (20)
- Duplicated statements with the editor.editEntityDocument api HOT 4
- Generic method to create new EntityDocument in WikibaseDataEditor
- Release? HOT 3
- Update Javadocs HOT 1
- Built-in server HOT 6
- Migrate to <dependencyManagement> to control versions of dependencies HOT 1
- Wrong password gives unclear message HOT 2
- Deserializing a property with `localMedia` datatype fails
- Remove datatype IRI from Wikibase data model implementation HOT 1
- Rename to Wikibase-Toolkit or something else? HOT 2
- OAuth2 support
- Incorrect behavior when converting multiple non-existent filenames to mids
- Support the new Wikibase REST API HOT 2
- Why does wdt use /other/wikidata/ instead of /wikidatawiki/entities/? HOT 3
- WbGetEntitiesAction cannot search media-info for titles containing "-" HOT 3
- Editing API: return revision id on successful edit HOT 5
- Drop support for Java 8
- JSON deserialization error in RdfSerializationExample
- WmfOnlineDailyDumpFile incorrectly checks for availability HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wikidata-toolkit.