Giter VIP home page Giter VIP logo

Comments (12)

gconnect avatar gconnect commented on August 10, 2024 1

image

image

image

image

Here is the link to the design https://www.figma.com/file/6gYtosgx6qt1RKRw922rfP/wikidashboard?node-id=107%3A161

@ujjwalagrawal17 and @ragesoss please review

from apps-android-wikiedudashboard.

ujjwalagrawal17 avatar ujjwalagrawal17 commented on August 10, 2024

The design looks great to me. Feedback from my end

  • I suggest we can use BottomSheetDialogs instead of expandable items in recyclerview in courses, editors, articles tabs.
  • Create Campaign Page should not be in the details page of campaign. Also, I think in our app we don't need this feature as of now.
  • Edit, Delete buttons can be there in the actions section. I am not sure how many people will use the download-stats feature. We can remove this if possible.
  • The values can be highlighted in (bold+accentColor) instead of the title in all 3 tabs(programs, editors, articles).
    Ex.- "Words Added" is a title and doesn't need attention. The value "5.6k" should be highlighted instead.

For WikiEdu Dashboard Some text changes will be there:
Programs -> Courses.
Editors -> Students.

from apps-android-wikiedudashboard.

ujjwalagrawal17 avatar ujjwalagrawal17 commented on August 10, 2024

Also toolbar title can be in black color.

from apps-android-wikiedudashboard.

gconnect avatar gconnect commented on August 10, 2024

Noted.Thanks for checking

from apps-android-wikiedudashboard.

gconnect avatar gconnect commented on August 10, 2024

image

image

image

image

from apps-android-wikiedudashboard.

gconnect avatar gconnect commented on August 10, 2024

Please review @ujjwalagrawal17

from apps-android-wikiedudashboard.

ujjwalagrawal17 avatar ujjwalagrawal17 commented on August 10, 2024

Looks good to me.

Instead of downarrow icon we can use 3 dot-menu icon.
The titles in the bottom sheet[articleName, studentName, courseName] are not very clear, we can add a divider between title and remaining section. Also, the font size of title can be increased.

from apps-android-wikiedudashboard.

gconnect avatar gconnect commented on August 10, 2024

Do you mean three dots vertically or horizontally?

from apps-android-wikiedudashboard.

gconnect avatar gconnect commented on August 10, 2024

image
image
image
image

from apps-android-wikiedudashboard.

gconnect avatar gconnect commented on August 10, 2024

Please review @ujjwalagrawal17

from apps-android-wikiedudashboard.

ujjwalagrawal17 avatar ujjwalagrawal17 commented on August 10, 2024

Looks perfect. We can start the implementation. 😁

from apps-android-wikiedudashboard.

ujjwalagrawal17 avatar ujjwalagrawal17 commented on August 10, 2024

Thanks @gconnect . Closing this issue.

from apps-android-wikiedudashboard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.