Comments (12)
Here is the link to the design https://www.figma.com/file/6gYtosgx6qt1RKRw922rfP/wikidashboard?node-id=107%3A161
@ujjwalagrawal17 and @ragesoss please review
from apps-android-wikiedudashboard.
The design looks great to me. Feedback from my end
- I suggest we can use BottomSheetDialogs instead of expandable items in recyclerview in courses, editors, articles tabs.
- Create Campaign Page should not be in the details page of campaign. Also, I think in our app we don't need this feature as of now.
- Edit, Delete buttons can be there in the actions section. I am not sure how many people will use the download-stats feature. We can remove this if possible.
- The values can be highlighted in (bold+accentColor) instead of the title in all 3 tabs(programs, editors, articles).
Ex.- "Words Added" is a title and doesn't need attention. The value "5.6k" should be highlighted instead.
For WikiEdu Dashboard Some text changes will be there:
Programs -> Courses.
Editors -> Students.
from apps-android-wikiedudashboard.
Also toolbar title can be in black color.
from apps-android-wikiedudashboard.
Noted.Thanks for checking
from apps-android-wikiedudashboard.
from apps-android-wikiedudashboard.
Please review @ujjwalagrawal17
from apps-android-wikiedudashboard.
Looks good to me.
Instead of downarrow icon we can use 3 dot-menu icon.
The titles in the bottom sheet[articleName, studentName, courseName] are not very clear, we can add a divider between title and remaining section. Also, the font size of title can be increased.
from apps-android-wikiedudashboard.
Do you mean three dots vertically or horizontally?
from apps-android-wikiedudashboard.
from apps-android-wikiedudashboard.
Please review @ujjwalagrawal17
from apps-android-wikiedudashboard.
Looks perfect. We can start the implementation. 😁
from apps-android-wikiedudashboard.
Thanks @gconnect . Closing this issue.
from apps-android-wikiedudashboard.
Related Issues (20)
- [sub-issue] Migrate Course details page - Students tab to MVVM
- [sub-issue] Migrate Course details page - Article tab to MVVM
- [sub-issue] Migrate Course details page - Uploads tab to MVVM
- [sub-issue] Migrate Course details page - Activity tab to MVVM
- Create a separate Kotlin file for each of the koin modules
- Add Project Setup Steps in Readme HOT 2
- [sub-issue] Migrate Media Details page from MVP to MVVM
- Refactor CampaignList, CourseList and Dashboard
- [BUG] Profile course detail and recent upload crashes HOT 4
- Profile page MVVM Migration
- [sus-issue] Campaign Details Page Home Tab
- [sub-issue] Campaign Details -Courses tab
- [sub-issue] Campaign Details - Article Tab
- [sub - issue ] Create Campaign Details - Student tab
- [BUG] HOT 1
- [BUG] Problem with gradle distribution version HOT 2
- MyDashboardFragment is leaking
- Crash while installing
- Fix travis HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apps-android-wikiedudashboard.