Use mw.config.get( 'wgNamespaceIds' ) instead of defining var Namespace directly in the code about twinkle HOT 3 CLOSED

I don't care a lot about this, other than the fact that the Namespace object has a different problem which suggests we should get rid of it: Firefox (at least) seems to have a built-in object called Namespace (XML-related, methinks), which we might want to use at some point down the road (unlikely, but still...).

$ grep "\WNamespace" modules/*.* *.* -c modules/twinklebatchdelete.js:4 modules/twinklebatchprotect.js:1 modules/twinklebatchundelete.js:1 modules/twinkledelimages.js:2 modules/twinkledeprod.js:2 modules/twinkleimagetraverse.js:2 modules/twinkleunlink.js:2 modules/twinklexfd.js:6 morebits.js:2

from twinkle.

Actually, having thought about this, I really prefer just using the namespace IDs as constants in code, ideally accompanied with a comment. Unlike compiled languages like C++, where using defined constants has no cost, JavaScript has to look up constants every time. And the namespace numbers aren't going to change anyway, so there is no problem of having to change the values.

from twinkle.

Done in 7db266c

from twinkle.