Giter VIP home page Giter VIP logo

Comments (4)

giacomovergnano avatar giacomovergnano commented on August 11, 2024
  1. I would also like to add a second questions if I may. It would be beneficial to use a static web generator in order to avoid repetition in HTML code for shared components such as header, footer, sidebar, etc
    Have you already decided against it, or are you open to a possible implementation? If so I could open another Pull Request with my edits

from wikimediaui-style-guide.

Volker-E avatar Volker-E commented on August 11, 2024

Hey @giacomovergnano, good to see you again!
Changing to a modular structure currently hasn't provided a strong enough, convincing benefit, given that we've also have, due to certain restrictions, other projects buidling on the main CSS prrovided here.

What were the arguments for a change from your perspective?

To your second point, yes. At length discussed in https://phabricator.wikimedia.org/T164449 but de-prioritized for other goals.
If you're interested, please participate in the discussion on Phabricator.

from wikimediaui-style-guide.

giacomovergnano avatar giacomovergnano commented on August 11, 2024

Hi @Volker-E thank you for your reply!
Point 1:
I was suggesting it because the setup of the Styleguide already allows it and from a maintainability and code navigation point of view I always have found easier to have different CSS modules for different utilities or style categories.
Indeed in the Styleguide case the code base is limited so the value might not be massive but for the same reason it makes it quite easy to implement at the moment.
Point 2:
Thank you for sharing the discussion, now I see it has indeed been discussed at length 😄
I will read through it.

Thank you and all the best!

Giacomo

from wikimediaui-style-guide.

Volker-E avatar Volker-E commented on August 11, 2024

We might pick this proposal up in future again, closing currently for lack of priority, resources versus clear benefit on further development vs other pressing issues.

from wikimediaui-style-guide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.