Comments (4)
- I would also like to add a second questions if I may. It would be beneficial to use a static web generator in order to avoid repetition in HTML code for shared components such as header, footer, sidebar, etc
Have you already decided against it, or are you open to a possible implementation? If so I could open another Pull Request with my edits
from wikimediaui-style-guide.
Hey @giacomovergnano, good to see you again!
Changing to a modular structure currently hasn't provided a strong enough, convincing benefit, given that we've also have, due to certain restrictions, other projects buidling on the main CSS prrovided here.
What were the arguments for a change from your perspective?
To your second point, yes. At length discussed in https://phabricator.wikimedia.org/T164449 but de-prioritized for other goals.
If you're interested, please participate in the discussion on Phabricator.
from wikimediaui-style-guide.
Hi @Volker-E thank you for your reply!
Point 1:
I was suggesting it because the setup of the Styleguide already allows it and from a maintainability and code navigation point of view I always have found easier to have different CSS modules for different utilities or style categories.
Indeed in the Styleguide case the code base is limited so the value might not be massive but for the same reason it makes it quite easy to implement at the moment.
Point 2:
Thank you for sharing the discussion, now I see it has indeed been discussed at length 😄
I will read through it.
Thank you and all the best!
Giacomo
from wikimediaui-style-guide.
We might pick this proposal up in future again, closing currently for lack of priority, resources versus clear benefit on further development vs other pressing issues.
from wikimediaui-style-guide.
Related Issues (20)
- Typography - specimen svg image does not display as expected
- SVG image for tpography-readability is missing spaces around links HOT 1
- [Typography] - what is the preferred treatment for system messages/alerts/dialogs? HOT 1
- Move resources to a different folder and use submodules HOT 13
- Move icons into its own repo HOT 4
- Load Resource 404 Error HOT 10
- Alerts in Components HOT 7
- Specify "common meaning" for utility colors HOT 4
- Add a link to the design team blog HOT 4
- Buttons look wrong in Firefox HOT 14
- Menu icon in mobile view off alignment HOT 4
- Increasing the width of color blocks HOT 6
- Text flowing off the page HOT 1
- Add more component design guidelines HOT 12
- Add "scroll to top" button in web page HOT 11
- Add "dark mode" button in the website HOT 21
- ADD follow section in footer! HOT 3
- Transform build scripts from Grunt to npm based scripts HOT 9
- Consider dropping Squoosh HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wikimediaui-style-guide.