Giter VIP home page Giter VIP logo

Comments (5)

wilkox avatar wilkox commented on May 19, 2024

I'm sorry about your package breaking – can you give me more details on the problem? I had intended for this release to be backwards-compatible.

I've pushed a fix for that bug to the dev version, you can install it with devtools::install_github('wilkox/treemapify').

from treemapify.

GregorDeCillia avatar GregorDeCillia commented on May 19, 2024

I was using the following call

dat <- treemapify(dat, area=x@area, fill=x@fill, label=x@key, group=x@gruppe)

where x is some S4 class capturing plot parameters. I totally don't mind reworking my code since the subgroup functionality seems like a very handy addition.

from treemapify.

wilkox avatar wilkox commented on May 19, 2024

Just pushed a dev release (58e6650, v2.5.0.9001) that restores fill and label as deprecated arguments, and group as an alias for subgroup. Would this fix the issue? I'll probably publish it to CRAN soon regardless to fix backwards compatibility for anyone who was calling against those arguments.

from treemapify.

GregorDeCillia avatar GregorDeCillia commented on May 19, 2024

Yes, the fix you provided in 899518c worked out well. As I said, I don't mind the interface changes and that was also not the reason I filed this issue - just the fact that I couldn't pass variables.

I've already adapted my project to an extend where I don't need the deprcated arguments anymore, but I can test them later today if you are interested.

from treemapify.

wilkox avatar wilkox commented on May 19, 2024

from treemapify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.