Infinite "Launching custom binary" loop due to symlinks in home directory path about dyre HOT 2 CLOSED

diff -ur ./Config/Dyre.hs ../modified-dyre/Config/Dyre.hs
--- ./Config/Dyre.hs 2010-04-30 11:07:19.000000000 -0500
+++ ../modified-dyre/Config/Dyre.hs 2010-08-04 16:08:59.000000000 -0500
@@ -84,7 +84,7 @@
module Config.Dyre ( wrapMain, Params(..), defaultParams ) where

import System.IO ( hPutStrLn, stderr )
-import System.Directory ( doesFileExist, removeFile )
+import System.Directory ( canonicalizePath, doesFileExist, removeFile )
import System.Environment ( getArgs )

import Control.Monad ( when )
@@ -124,6 +124,8 @@
else do
-- Get the important paths
(thisBinary, tempBinary, configFile, cacheDir) <- getPaths params

•    thisBinary' <- canonicalizePath thisBinary
  

•    tempBinary' <- canonicalizePath tempBinary
  
   -- Check their modification times
   thisTime <- maybeModTime thisBinary
  

  @@ -150,7 +152,7 @@
  -- gone.
  errorData <- getErrorString params
  customExists <- doesFileExist tempBinary

•    if confExists && customExists && (thisBinary /= tempBinary)
  

•    if confExists && customExists && (thisBinary' /= tempBinary')
      then launchSub errorData tempBinary
      else enterMain errorData
  

  where launchSub errorData tempBinary = do

from dyre.

I understand the problem in theory, but the description of the specific setup that caused it is slightly confusing, so I haven't tested for myself that it works. But since the fix makes sense in principle and doesn't break any ordinary use patterns, it may as well be added.

Dyre v0.8.4 is uploaded to Hackage now, which contains essentially the same changes as you suggested.

At some point, it may be worthwhile to compare files based on inode number with System.Posix.Files.fileID, but since no one's complained yet, the added complexity probably isn't worth it.

from dyre.