Comments (5)
Thanks again for catching another bug, @tibotiber :)
I went through my code and just realized I probably did something strange here. The drag/drop tracking was implemented in Space (https://github.com/williamngan/pts/blob/master/src/Space.ts#L443), so looks like it was re-implemented again in UI. That's most likely why the 'drop' event was triggered twice.
I'll look into it more closely soon. If you want to propose a fix, that would be most welcomed too. (I'm currently traveling so apologies if my responses are delayed.)
Thank you so much!
from pts.
I’ll try to have a look if I can carve some time. Next days are looking busy though. No worries for delayed response, we’re lucky enough you open sourced this ;)
from pts.
Finally got some time to dive in this. Posted a PR, and will open another issue we can address separately if you want.
from pts.
Hi @tibotiber - thank you so much for digging into this issue and fixing it too! Really appreciate your help. :)
from pts.
My pleasure. Really loving what you did with this lib :)
from pts.
Related Issues (20)
- sound demos HOT 1
- source-map file missing when importing pts
- Canvas size issue when html attribute and css style width & height differs. HOT 4
- Fix parameter types HOT 1
- CanvasForm(ctx) methods error. HOT 3
- Implement oklab color
- will pts provide an api to render in existing canvas provided by the user? HOT 2
- pts.js, pts.min.js added to .npmignore and are not served by cdns any longer HOT 2
- Documentation is unclear on how to "unmount" a canvas. HOT 2
- Radial gradients can't use negative coordinates HOT 2
- Safari 15 // Group.moveTo not reflected HOT 5
- Crisp 1px lines on HiDPI devices. HOT 1
- Canvas mouse events coord is wrong on layout change HOT 1
- Add support for roundRect method. HOT 1
- randomPt overwrites input value
- error on form methods when using with an existing canvas HOT 2
- Drawing tools
- Drawing tools
- Add brush like this one https://p5-brush.cargo.site/? HOT 1
- Built-in SVG interactions HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pts.