Giter VIP home page Giter VIP logo

Comments (13)

nstoya avatar nstoya commented on August 11, 2024 3

With typescript v5 it fails with the same error when trying to build.

from nestjs-prometheus.

willsoto avatar willsoto commented on August 11, 2024 1

Perhaps VSCode isn't using whatever tsconfig the runtime is using?

from nestjs-prometheus.

willsoto avatar willsoto commented on August 11, 2024

What version of TypeScript?

from nestjs-prometheus.

ozelen avatar ozelen commented on August 11, 2024

@willsoto , 4.3.5

from nestjs-prometheus.

willsoto avatar willsoto commented on August 11, 2024

Works for me on TS 4.9.5

4.3.5 is a very old version of TypeScript though. You should try upgrading and, if it's still broken, creating a minimal reproduction or a failing test case.

from nestjs-prometheus.

ozelen avatar ozelen commented on August 11, 2024

Agree. I updated TS version. Still see the error, but it's only visible in VSCode, not runtime. Like follows
image

from nestjs-prometheus.

willsoto avatar willsoto commented on August 11, 2024

Try reloading VSCode?

from nestjs-prometheus.

ozelen avatar ozelen commented on August 11, 2024

tried already, didn't help though. Weird thing...

from nestjs-prometheus.

ozelen avatar ozelen commented on August 11, 2024

Looks like the plugin JavaScript and TypeScript Nightly works incorrectly. When I turned it off, the problem disappeared (along with some validation hinting though :), but VSC started performing much better).

from nestjs-prometheus.

willsoto avatar willsoto commented on August 11, 2024

👍

from nestjs-prometheus.

willsoto avatar willsoto commented on August 11, 2024

Please confirm it's not the same issue with the same resolution mentioned here: #1667 (comment)

If you believe it's actually an issue with v5, please open a new issue with a minimal reproduction of the problem.

from nestjs-prometheus.

Nicklason avatar Nicklason commented on August 11, 2024

Please confirm it's not the same issue with the same resolution mentioned here: #1667 (comment)

If you believe it's actually an issue with v5, please open a new issue with a minimal reproduction of the problem.

I have the same problem. This reproduces the problem. I have also fixed the problem and I am making a pull request for it right now.

from nestjs-prometheus.

willsoto avatar willsoto commented on August 11, 2024

🎉 This issue has been resolved in version 5.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

from nestjs-prometheus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.