Giter VIP home page Giter VIP logo

Comments (6)

Wilm0r avatar Wilm0r commented on June 24, 2024

Agreed, I figured a few weeks ago that I'm going to have to add this to Giggity. When I wrote the parser, IIRC Pentabarf files didn't have useful tz info yet (also Java tz APIs were terrible, fortunately I've adopted a more modern one kinda recently which is going to be useful here).

When I considered implementing this earlier, I couldn't really figure out what to do UI-wise. But I guess it should just read all times with tz info and offer a choice between showing conf-local or user-local times (when they differ at all).

from giggity.

Wilm0r avatar Wilm0r commented on June 24, 2024

This came up in #164 too, and I've managed to fix it in time before that event :-)

Behaviour is not configurable and will work only with Pentabarf files with those timestamps. Note that this is not in all Pentabarf style files for example not in FOSDEM's schedule: https://fosdem.org/2020/schedule/xml — it has only blocks with naive times, not the full-ISO8601 ones. But files that do, like HOPE and many others (in fact FOSDEM is the only exception I found so far) will now be parsed with timezone offset.

Then when tz offset is different from the phone's configured tz, the times will be converted, and the nav drawer will mention the offset as an FYI.

Alerts should all work properly now. Maybe later I'll add a setting to show event-local times. I think everything else it timezone-clean enough that this should work properly. (One could possibly try by just changing tzNative in Schedule.java.

from giggity.

Wilm0r avatar Wilm0r commented on June 24, 2024

2.0.6 released on Play and hopefully soon F-Droid (depends on when their bot scans the repository)

Since some confs like FOSDEM don't have this info, and since hour offsets are less useful than actual timezone info, I wonder whether I'll just add a tz field to menu.json for more complete support later.

from giggity.

Art1910 avatar Art1910 commented on June 24, 2024

Updated on F-Droid + fixed my issue with the DebConf2020 schedule joining from UTC+2.
TYVM

from giggity.

Wilm0r avatar Wilm0r commented on June 24, 2024

Since some confs like FOSDEM don't have this info, and since hour offsets are less useful than actual timezone info, I wonder whether I'll just add a tz field to menu.json for more complete support later.

IIRC I saw that Debconf does have a timezone header in its files somewhere which sounds useful. Guess support for that is worth keeping this bug open for.

from giggity.

Wilm0r avatar Wilm0r commented on June 24, 2024

a079f48 did this already.

from giggity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.