Allow `c` option for confirmation when using Acks about ferret HOT 7 CLOSED

So I just took a look and I think that the sanity check that is being done here just needs to be removed. It was a good thought, but there are too many variables for how a user can decide to create a substitution pattern. Passing the value through with no checks is the better option. Let argdo blow up if something isn't right.

from ferret.

I'm open to making the sanity check more flexible, but not removing it.
On Sat, Aug 1, 2015 at 2:06 AM Jeff Felchner [email protected]
wrote:

So I just took a look and I think that the sanity check that is being done
here
https://github.com/wincent/ferret/blob/master/autoload/ferret/private.vim#L242-L245
just needs to be removed. It was a good thought, but there are too many
variables for how a user can decide to create a substitution pattern.
Passing the value through with no checks is the better option. Let argdo
blow up if something isn't right.

—
Reply to this email directly or view it on GitHub
#17 (comment).

from ferret.

@wincent I'll look into it.

from ferret.

I'm thinking it can be as simple as changing the regex to something like '\v^(.).+\1.*\1c?$, and then passing the c through if present.

from ferret.

@wincent was something like this merged in?

from ferret.

Yes. See the commit linked above (937d61b), currently in master.

from ferret.

Cool! Thanks!

from ferret.