Comments (1)
@charlesfries Hey, thanks for the issue!
I took a quick look at the reproduction (thanks for that!) and it seems to be related to the value being updated while the breadcrumbs update loop isn't finished yet. This check fails, so the value isn't updated. It seems that it consistently works if you use run.later
or next
instead of setTimeout since by then the flag should be reset.
I'm not sure how this can be fixed in the addon though. That check is there to prevent infinite loops (since the addon forces a rerender) so removing it is not an option. I also don't see a way to tell the service that a specific update is fine. The only thing I can think of is adding some sort of diff checking to determine if the title and data has changed, but since the data object is fully user controlled that doesn't sound ideal either.
Can you provide more information about the real setup where you are running into issues?
All of these timing issues kind of confirm that using templates for things like this might not be the best solution (since it requires runloop hackery) and a "route based" breadcrumbs setup would skip all these issues, but the helper based API is so nice from a consumer point of view 😄. Ideally the helper would be an "effect", but that isn't a thing so I tried to mimic that behavior with the runloop. As you noticed, it's far from perfect 😄.
from ember-breadcrumb-trail.
Related Issues (14)
- Auto-capture RouteInfo HOT 4
- Add FastBoot tests HOT 1
- Rendering timing issue HOT 2
- Set up Github actions
- v2 addon conversion
- Fix the Ember v4 CI jobs
- Investigate a "Route-based" solution
- Configure release-it
- set up `@embroider/test-setup` HOT 1
- Add isFirst / isLast flags to the BreadcrumbData object HOT 1
- "reverse" breadcrumbs option HOT 1
- Cache `BreadcrumbsService.items`
- Provide a public way to access the breadcrumbs in JS code HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-breadcrumb-trail.