Comments (16)
Well, I could conditionally use V8's new Private
interface instead of the depreciated HiddenValue
interface, but the documentation for V8 5.3.332.45 states that the Private
interface is experimental. I find that strange because, if they removed HiddenValue
in that version, it can't be that experimental (as there are no other alternatives).
That said, I'm happy to go ahead and try it out. Give me a day to try it and test it. If it goes well, I'll publish a new patch and close this issue.
from better-sqlite3.
(Just a heads up that I threw together a patch that resolves this on https://github.com/bengotow/better-sqlite3 — the issue we're having with node-sqlite is a pretty big one, so we're using better-sqlite3 to see if it's due to a Node 6 + node-sqlite issue. Will submit it as a PR once we've done some more testing.)
from better-sqlite3.
It looks like you're using an incompatible version of V8. Do you know which version of V8 is being used in Electron 1.4.1?
from better-sqlite3.
Looks like Electron is using V8 5.3.332.45. Here's the full print out I get from process.versions
in our app, in case any of these are also relevant:
chrome:"53.0.2785.113"
electron:"1.4.0"
modules:"50"
node:"6.5.0"
uv:"1.9.1"
v8: "5.3.332.45"
Do you know how hard it'd be to update those couple references? I haven't migrated between V8 versions before, but it looks like the node-sqlite
folks did recently so the changes may be the same.
from better-sqlite3.
Ahh cool—it looks like they removed HiddenValue (https://codereview.chromium.org/1942233002) in V8 5.2. I wonder when Private
was added? Anyway—thanks for taking a look. If you get it going on a branch or something, I'm happy to plug it into N1. It's probably a pretty good stress test :-)
from better-sqlite3.
Great! I apologize for not getting to it first. I didn't have time before leaving for a vacation, but normally I try to be very responsive about issues like this. I'm glad you were able to resolve it. I look forward to hear the results of your testing
from better-sqlite3.
Running into the same issue here. Any fix available?
I can't install any sqlite3 package at all, since every package I try stops with the gyp-horror.
from better-sqlite3.
@Steviey there's a number of articles out there explaining how to install the sqlite3 + electron, you basically need to run electron-rebuild to recompile it against the electron headers and it should work. (confirmed for me with Electron 1.4.1 + SQlite3 on MacOS)
The issue with this package is a different one entirely, related to chromium V8 versions...
from better-sqlite3.
The fix is currently a WIP via #3.
from better-sqlite3.
@alexweber unconfirmed on Win7
from better-sqlite3.
Hey! If the patch above didn't fix it for you, it's most likely an issue with your build environment - the discussions in the node-sqlite3 issue tracker should still be helpful if you're using better-sqlite3. (On windows, I think you might need visual studio and some other things, but I'm not sure.)
from better-sqlite3.
@Steviey oops, sorry didn't catch that.
from better-sqlite3.
Edit: For the time being, I'm using @bengotow's patch on a fork of the latest better-sqlite3 master
and everything seems to be working fine.
I'm also working with Electron and trying to get this plugin working. @bengotow, after @JoshuaWise cleaned up some sections of code on October 12 per this comment, is your patch for Electron still working for you?
It looks like you are still using your forked better-sqlite3 repo on Nylas/N1 -- is your plan to stay forked or to try merging these again?
Or does it make sense to push the changes needed for Electron into a permanent fork like better-sqlite3-electron, that can stay updated with @JoshuaWise's repo while the Electron community can tweak the code as needed?
from better-sqlite3.
#2 (comment) fix by @bengotow working for me.
I m using "better-sqlite3": "bengotow/better-sqlite3#a888061ad334c76d2db4c06554c90785cc6e7cce"
in package.json
.
Taken from nylas package.json.
from better-sqlite3.
Hi @bengotow, I heard that sqlite is working quite well in N1 email client, in a video. And I see that you are using better-sqlite3 instead of sqlite3 package. I m facing some itermittent issue with sqlite3 (issue: TryGhost/node-sqlite3#742).
How is your experience with better-sqlite3 regarding stability & performance of better-sqlite3? I m interested because better-sqlite3 has sync api and claims it has much more performance than sqlite3.
from better-sqlite3.
Electron is now supported by better-sqlite3
v1.4.0 👍
from better-sqlite3.
Related Issues (20)
- Release 9.4.4 misses native artifacts HOT 4
- I can't install this package HOT 4
- BigInt values is queries incorrectly HOT 1
- Using drizzle-kit with better-sqlite3 in an electron application HOT 1
- Update SQLite to version 3.45.2 HOT 1
- 7.6.1 does not build on Linux HOT 4
- treatment of default column aliases when none are specified HOT 3
- nodejs v20.12.2 python.exe v3.12 VS2017/2022 don‘t’ install better-sqlite3, ask for help HOT 1
- Error: Error relocating /nodejs/app/node_modules/better-sqlite3/build/Release/better_sqlite3.node: _ZN2v89Exception10RangeErrorENS_5LocalINS_6StringEEE: symbol not found HOT 1
- Is there any solution to speed up the UPDATE command? HOT 1
- cannot start from a readonly path HOT 2
- Add prebuilds for Node.js 22 HOT 2
- Missing v10.0.0 prebuilt packages for darwin-x64 and linux-arm HOT 10
- Support parameters names in exactly the syntax in which they are used in the query HOT 2
- Better-sqlite3 not working on termux HOT 1
- Uncaught TypeError:Cannot read properties od null(reading 'access‘) at node_modules/better-sqlite3/lib/methods/backup.js HOT 2
- Prebuild compilation error on win32-arm64 + Electron v25 HOT 9
- vscode extension use better-sqlite3 error HOT 1
- No prebuilt binaries found (target=20.14.0 runtime=node arch=arm64 libc= platform=win32) HOT 3
- error /Users/praveen36singhq/Desktop/nimbold/bit-chainit-id/node_modules/better-sqlite3: Command failed. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from better-sqlite3.