Comments (6)
For problem 1, it's because WrappedCurio::getDynamicModifiers
invokes AccessoryAttributeBuilder::addExclusive
, which use Map<ResourceLocation, AttributeModificationData>
. It should be using Map<Holder<Attribute>, Map<ResourceLocation, AttributeModificationData>>
or Table<Holder<Attribute>>, ResourceLocation, AttributeModificationData>
instead.
from accessories.
- Is the problem that
AttributeModifier
across multipleAttribute
share the sameResourceLocation
or is it the fact that multipleAttributeModifier
have the sameResourceLocation
for a singleAttribute
from accessories.
@Dragon-Seeker The problem is having several AttributeModifier
s sharing the same ResourceLocation
for multiple Attribute
s
The method provides a ResourceLocation
that wants the accessory to use for its attribute modifiers. The issue 1 can technically be solved by appending a different suffix for every modifier, but most mods are not doing that
from accessories.
Ah, that is really odd and frankly concerning as the ResourceLocation
would be unique across all AttributeModifier
's but Minecraft doesn't enforce such even though they merged the id and name into one field to uniquely identifier the attribute with info about why or naming the modifier instance so it kind seems lazy to just share across every modifer but I guess since vanilla allows such I will need to adjust such even if I feel that this should not happen its just not enforced.
- I did not know the API functioned like such as it is quite odd, to say the least. I understand its reasons but I believe that Accessories should attempt to use the Vanilla method
ItemStack.addModifierTooltip
and any mods should attempt injection within there to adjust the Attribute tooltips. Understandable that currently, this affects the Curios API but I don't really know exactly fix such an issue as the Accessories API isn't designed for such. Frankly, I don't want to redesign this as it seems like the incorrect method to deal with this.
from accessories.
The tooltip modification part is there to help with the missing Attribute tooltip customization from Forge/NeoForge. I think there is a PR regarding this in NeoForge currently?
from accessories.
If this PR is completed, I wouldn't need to use the odd attribute tooltip method
neoforged/NeoForge#1371
from accessories.
Related Issues (20)
- Server crashes after updating tclayer accessories Fabric 1.21 HOT 2
- Mislabeling of Curseforge upload HOT 1
- [1.21][Neoforge] Crash when add extra slot via config HOT 2
- [Bug] Dropped accesories on death - Incompatiblity with Revive HOT 14
- [Bug] Incompatible with the Affinity mod - Endec Version Issues HOT 4
- Sophisticated Backpacks GUI rendering incorrectly + Some items from Artifacts don't apply their effects. HOT 3
- Incompatibilities w/ spartan weaponry & simple hats HOT 20
- [Bug] Inconsitent Map equip action with Map Atlases [Forge] HOT 3
- [Bug] Null base amount crashing if add/subtract operation occurs before such being set HOT 5
- Always Visible UI HOT 1
- [Bug] Incompatibility with "Iron's Spells 'n Spellbooks" Curios Slot "Spellbook" [NeoForge 1.20.1] HOT 2
- [1.21.x][Neoforge] CC layer Beta7 causing game to freeze on launch
- Crash with latest versions, mixin inject failed HOT 3
- Crash - Spell Engine? HOT 3
- [Glitch] Invisible trinkets in multiplayer HOT 7
- Accessories + Curios Compat Layer 1.20.1 crash with Embeddium Extra or Radium HOT 1
- Create Engineer Goggles doesnt show overlays when equipped as an Accessory HOT 3
- [Feature] Visual Slot indication HOT 1
- Proxy Incompatibility
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from accessories.