Astro devToolBar audit create a warning on code block about starlight HOT 4 CLOSED

Actually, just chatted with the team and looks like it is a valid issue because the code snippets generate tabindex statically at build time, but we don’t have any dynamic code to remove those on non-scrollable code snippets (or add back when the window resizes etc.)

@OliverSpeir is going to look into fixing this upstream in https://github.com/expressive-code/expressive-code, which we use for code block rendering. Thanks again for raising it!

from starlight.

Created an issue to track this in the Expressive Code repo to track this and added some more context and research I collected there: expressive-code/expressive-code#138

Will close this issue as this will need fixing upstream. Thanks again for bringing our attention to this @NicolasRenault 🙌

from starlight.

Thanks for the issue! I think this is actually a false positive in the dev toolbar. Code samples are focusable (thanks to the tabindex attribute) so that keyboard users can focus and scroll them.

from starlight.

Wow you guys are quick !
Thanks you both.

from starlight.