Comments (6)
Thanks for the patch suggestion @phuongwd, I will check that now 🙂
from react-native-navigation.
The fix will be released in the next patch version. @phuongwd you will both get credit in the release notes 😄
from react-native-navigation.
Related to
Patch
diff --git a/node_modules/react-native-navigation/lib/ios/RNNTabBarItemCreator.m b/node_modules/react-native-navigation/lib/ios/RNNTabBarItemCreator.m
index d313bfc..c22f984 100644
--- a/node_modules/react-native-navigation/lib/ios/RNNTabBarItemCreator.m
+++ b/node_modules/react-native-navigation/lib/ios/RNNTabBarItemCreator.m
@@ -91,13 +91,19 @@
NSNumber *fontSize = [bottomTabOptions.fontSize withDefault:@(10)];
NSString *fontWeight = [bottomTabOptions.fontWeight withDefault:nil];
+ /**
+ * The title of tabbar item has been cut off in iPad 12.9 with iOS 15.4.
+ * It was mentioned at https://github.com/wix/react-native-navigation/issues/7506
+ * Hotfix: centered the text will resolve problem.
+ */
+
NSDictionary *normalAttributes = [RNNFontAttributesCreator
createFromDictionary:[tabItem titleTextAttributesForState:UIControlStateNormal]
fontFamily:fontFamily
fontSize:fontSize
fontWeight:fontWeight
color:textColor
- centered:NO];
+ centered:TRUE];
[self setTitleAttributes:tabItem titleAttributes:normalAttributes];
NSDictionary *selectedAttributes = [RNNFontAttributesCreator
@@ -106,7 +112,7 @@
fontSize:fontSize
fontWeight:fontWeight
color:selectedTextColor
- centered:NO];
+ centered:TRUE];
[self setSelectedTitleAttributes:tabItem selectedTitleAttributes:selectedAttributes];
}
from react-native-navigation.
Fix is here: #7863, will release a patch version soon
from react-native-navigation.
Thanks for the patch suggestion @phuongwd, I will check that now 🙂
Credit to thuongtv-vn #7506 (comment)
from react-native-navigation.
Released with 7.38.4
from react-native-navigation.
Related Issues (20)
- Event RNN.ComponentDidAppear called before render screen component when animations.showModal.enabled = false
- Header Style Shadows warnings can't be disabled
- Android - Left buttons are not in order
- Android Regression RN 0.73 - `onDropViewInstance` not called anymore, View not cleaned up
- All bottom tab components load when a text input is pressed and the keyboard opens
- BottomTabs shows a top solid border when content is scrolled to the bottom edge on iOS 15 HOT 1
- Right-hand buttons flicker on Android
- Fabric is not working on IOS. HOT 1
- Compile error after upgrading from 7.38.3 to 7.38.6 HOT 2
- Android windowSoftInputMode not respected, keyboard always resizes view
- Does react-native-navigation work completely on Main Thread? Will it work if JS thread is blocked? HOT 1
- Android is not following the Appearance API from react-native HOT 4
- RN 0.74 New Architecture Support HOT 7
- App crashes with more than 5 tabs
- Incorrect rendering order of initial tab
- Xcode 15 RN 0.59 error: UIViewController is missing its initial trait collection populated during initialization HOT 3
- Title and subtitle test ID's
- ReactTextShadowNode.UNSET is not available on RN 0.74.1 HOT 13
- Getting Execution failed for task ':react-native-navigation:compileReactNative71DebugJavaWithJavac HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-navigation.