Comments (1)
Thanks for the report. This is an issue I have encountered too. It is related to the way Matlab's integral
function works.
This suggests that replacing the anonymous function with a regular function could result in a marginal speedup. You could consider testing this and making a pull request if this results in a speedup.
Alternative approaches would involve either (1) changing the equation to something that is quicker to solve, or (2) changing the default solving tolerances of the integral
function as described here as well. Either of these approaches has the downside of affecting the model simulations. For (1), using a different function than the integral will obviously result in different simulations. For (2), loosening the tolerances will affect the accuracy of the integral solution and this will (likely) lead to different simulations also.
A final option may be having an in-depth look at the integral
function to figure out how it computes the integral, and see if there is something special in the MARRMoT case that lets us somehow short-circuit part of the solving. Intuitively I doubt this will be the case.
Summarizing, a slight speedup might be achievable fairly easily. Larger speedups are likely not possible without changing this flux equation and thus changing the model simulations. I'll leave this open for a while in case you want to try replacing the anonymous function with a real one.
from marrmot.
Related Issues (16)
- implementing time by bmi standards
- grids not implemented yet HOT 1
- BMI implementation of get_value_at_indices still not working in python
- Config file using ERA5
- BMI interface returns wrong data types HOT 4
- BMI var names inconsistent HOT 2
- add BMI description to main readme file
- Low computing efficiency HOT 4
- JacobPattern error in `m_28_xinanjiang_12p_4s` HOT 1
- m_13_hillslope_7p_2s.m flux order error HOT 1
- Implement a hot-start functionality
- Models sometimes return small-ish negative values
- parfor in my_cmaes.m throws an error! HOT 5
- GR4J leads to odd threshold behaviour for certain parameter sets
- Doubling up on GR4J's X4 parameter
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from marrmot.