SigmaCrit units about evillens HOT 4 CLOSED

I fixed the code so that it returns Msolar/Mpc^2 in the test case. Not sure if it is a perfect fix though. Let me know if there are any issues.

from evillens.

This fails for me:

import evillens as evil
lens = evil.GravitationalLens(0.4,1.5)

astropy.units.core.UnitsException: 'kg / (m)' and 'solMass / (Mpc2)'

are not convertible

Something's up! Also, I think units already knows about "Msun" as a unit of
mass - is this just a proxy for solMass?

On Tue, Sep 30, 2014 at 1:56 PM, Warren Morningstar <
[email protected]> wrote:

I fixed the code so that it returns Msolar/Mpc^2 in the test case. Not
sure if it is a perfect fix though. Let me know if there are any issues.

—
Reply to this email directly or view it on GitHub
#2 (comment).

from evillens.

Yeah, Msun and M_sun are both proxies for solMass.

As for the bug, I think I know what is happening. The function self.cosmological_angular_diameter_distance(z) for you might be returning a unitless output (while for me it returns a value with units of Mpc). If this is true, then the value of SigmaCrit would be in kg/m, since c/G returns a value with those units.

Try this:
import lens as evil
lens = evil.GravitationalLens(0.4,1.5) #this should make the error message you got, but it performs the earlier steps anyways.
print(self.Ds, self.Dd, self.Dds)

and see if the output is unitless.

from evillens.

Fixed by using anaconda python...

from evillens.