[SFTP] Handle size found was too big about wolfssh HOT 3 CLOSED

Hi bagder,

Thank you for the report. I'm looking into reproducing the problem. In the mean time if this is being induced by a call to wolfSSH_SFTP_Open please have the input argument "handleSz" set to a length of 256 with a matching "handle" input buffer that is at least 256 bytes (or WOLFSSH_MAX_HANDLE from wolfssh/wolfsftp.h). This is the max handle size that can be sent across according to the RFC and it may be that the buffer being passed in is too small to hold the handle found from the SFTP packet.

Regards,
Jacob

from wolfssh.

Hi @bagder,

After looking over the branch linked to I think setting the handleSz will resolve the issue.

In lib/wolfssh.c

507     case SSH_SFTP_DOWNLOAD_INIT:
(add)     sshc->handleSz = WOLFSSH_MAX_HANDLE; /* size of "handle" buffer in struct from lib/ssh.h */
508       rc = wolfSSH_SFTP_Open(sshc->ssh_session, sftp_scp->path,
509                              WOLFSSH_FXF_READ, NULL,
510                              sshc->handle, &sshc->handleSz);

~jacob

from wolfssh.

Yes, that seems to fix it!

Can I suggest you document this somewhere? I was certainly not obvious to me...

from wolfssh.