32bit Linux built echoserver using ECC key segmentation fault about wolfssh HOT 8 CLOSED

Hi skhasan, thanks for reaching out to us! Can you walk me through the build steps taken? How was wolfSSL configured i.e. ./configure --enable-ssh, and how was wolfSSH configured? I gave this a quick try checking out those exact versions (1.4.3 and 4.3.0) on a 32bit Ubuntu VM using "./examples/echoserver/echoserver -E" and "./examples/echoserver/echoserver -e".

Also does the issue go away if building wolfSSL with "--enable-sp --enable-sp-math"? That tells wolfSSL to use a different math library.

from wolfssh.

Hi Jacob, Nice to meet you and thanks.

How was wolfSSL configured i.e. ./configure --enable-ssh

That's right. Only "--enable-ssh" has been used.

how was wolfSSH configured?

Default configuration. i.e. ./configure

I gave this a quick try checking out those exact versions (1.4.3 and 4.3.0) on a 32bit Ubuntu VM

Did you able to reproduce the issue?

Also does the issue go away if building wolfSSL with "--enable-sp --enable-sp-math"?

No. Instead the following build-error occurred -

src/internal.c: In function ‘wolfSSH_oct2dec’:
src/internal.c:8721:15: warning: implicit declaration of function ‘mp_todecimal’; did you mean ‘mp_tohex’? [-Wimplicit-function-declaration]
ret = mp_todecimal(&tmp, decimalString);
^~~~~~~~~~~~
mp_tohex
src/internal.c:8721:15: warning: nested extern declaration of ‘mp_todecimal’ [-Wnested-externs]
CC src/libwolfssh_la-log.lo
CC src/libwolfssh_la-io.lo
CC src/libwolfssh_la-port.lo
CCLD src/libwolfssh.la
CCLD examples/client/client
CCLD examples/server/server
/usr/bin/ld: src/.libs/libwolfssh.so: undefined reference to `mp_todecimal'
collect2: error: ld returned 1 exit status

from wolfssh.

Thanks for giving the --enable-sp a try. I have not been able to reproduce it yet, with the default configure on one of the 32 bit systems at the office here. I will give it a try on another one that we have to see if it can be reproduced there.

Can you give us a stack trace of where it is failing? To do this I suggest compiling wolfSSL with "./configure --enable-ssh --enable-debug" and wolfSSH with "./configure --enable-static --disable-shared --enable-debug" then running "gdb ./examples/echoserver/echoserver -e".

from wolfssh.

Sorry for my late reply.
Here is the stack trace log:

(gdb) bt
#0 0xb7f7aedd in mp_zero () from /usr/local/lib/libwolfssl.so.19
#1 0xb7f7b3d7 in mp_read_unsigned_bin () from /usr/local/lib/libwolfssl.so.19
#2 0x0040db43 in DoUserAuthRequestEcc (ssh=0x425840, pk=0xbfffeb5c, hashId=6 '\006',
digest=0xbfffe9dc "~/\243\037\350\061Ӡ\376\226\357\376\273\311\036@W\240\031\330\002\265o\344\336\062\321\r\271\246\347v", digestSz=32) at src/internal.c:3515
#3 0x0040e1d2 in DoUserAuthRequestPublicKey (ssh=0x425840, authData=0xbfffeb40, buf=0x426696 "",
len=277, idx=0xbfffeb84) at src/internal.c:3696
#4 0x0040e3cc in DoUserAuthRequest (ssh=0x425840, buf=0x426696 "", len=277, idx=0xbfffebb0)
at src/internal.c:3757
#5 0x004100ac in DoPacket (ssh=0x425840) at src/internal.c:4639
#6 0x004113f9 in DoReceive (ssh=0x425840) at src/internal.c:5177
#7 0x00405491 in wolfSSH_accept (ssh=0x425840) at src/ssh.c:483
#8 0x00403654 in server_worker (vArgs=0x4272e0) at examples/echoserver/echoserver.c:398
#9 0x004045cd in echoserver_test (args=0xbffff1dc) at examples/echoserver/echoserver.c:1093
#10 0x0040469a in main (argc=2, argv=0xbffff2a4) at examples/echoserver/echoserver.c:1136
(gdb)

from wolfssh.

Sorry, this issue is still in opened state.

from wolfssh.

Thanks, the stack trace helps. I have a suspicion of what is happening now. Am working on verifying it and a code change if needed.

from wolfssh.

@skhasan I opened a PR that resolved the issue when testing locally.

from wolfssh.

Thank you so much for the fix.
I confirm that echoserver is now running on 32bit Linux with ECC key.

from wolfssh.