Giter VIP home page Giter VIP logo

Comments (5)

wonkooklee avatar wonkooklee commented on June 25, 2024 1

소중한 의견 주셔서 정말정말 감사합니다. 불필요하게 alert을 띄워 사용자의 불편감을 야기하는 것은 말씀하신 바와 같이 좋은 방식이 아닌 것 같습니다. alert 다이얼로그 대신 버튼 위에 작게 툴팁 같은 메시지(e.g. '잘못된 형식의 주소입니다')를 띄우는 방법으로 교체하고, 이미지의 유효성을 비동기적으로 확인할 수 있는 별도의 validation process를 연구하겠습니다. 감사합니다 🙇🏻

from thumbnail_maker.

bolam-o avatar bolam-o commented on June 25, 2024

즉각적인 피드백 감사합니다! 전달드리고 싶은 내용이 전달되었으니 해당 이슈는 닫도록 하겠습니다. 😊

from thumbnail_maker.

wonkooklee avatar wonkooklee commented on June 25, 2024

감사합니다 🥰

from thumbnail_maker.

raejoonee avatar raejoonee commented on June 25, 2024

정규표현식을 사용해서 유효한 주소인지 검증하는 방법은 어떨까요?

const regex = /((([A-Za-z]{3,9}:(?:\/\/)?)(?:[-;:&=\+\$,\w]+@)?[A-Za-z0-9.-]+(:[0-9]+)?|(?:www.|[-;:&=\+\$,\w]+@)[A-Za-z0-9.-]+)((?:\/[\+~%\/.\w-_]*)?\??(?:[-\+=&;%@.\w_]*)#?(?:[\w]*))?)/;
let imgUrl = prompt('이미지 주소를 입력하세요 😇'); 
if (imgUrl === null) return; // 취소 눌렀을 때 알림이 발생하지 않도록
if (!imgUrl.match(regex)) { // 유효하지 않은 주소를 입력했을 때 알림 발생
  alert('올바르지 않은 URL입니다 😨'); 
  return; 
}; 

from thumbnail_maker.

raejoonee avatar raejoonee commented on June 25, 2024

해당 이슈 관련하여 PR을 열었는데, 확인해주시면 정말 감사드리겠습니다 😊

from thumbnail_maker.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.