Warning for missing `console` syntax about lowlight HOT 9 CLOSED

remark-highlight.js 4.0.1 is out with this fix.

from lowlight.

The weird part is: webpack emit a warning, which actually is an error (modules are skipped...). Maybe you should emit a warning and not fail, as highlight.js does? (Highlight.js silently fail and does not even emit a warning actually)...
I have a website (putaindecode.io) which use a lot console syntax and I am afraid to update now :D

from lowlight.

Thanks for raising this here @MoOx!

Here’s the code in Highlight.js: L495-L498, here’s the relative code in Lowlight: L349-L355.

By comparing those two, they both throw an error (albeit the Lowlight one is more cryptic, so that should be fixed).

Highlight.js silently fail and does not even emit a warning actually

Could that be the difference between the setup in highlight and lowlight? As in, through Webpack, or remark-highlight.js? From what I read in the code, both should throw an error if the language isn’t available.

How did the previous set-up of remark-highlight handle console highlighting? Did it ignore the code-block? Maybe the solution is to ignore highlighting blocks with unknown flags, or warn instead of throwing?

from lowlight.

It using remark-highlight.js spawn by a webpack loader :D
I were just using remark-highlight.js which was using highlight.js directly, and I "just" upgraded to the new version using lowlight (btw, great name haha).

Previously this was not throwing any error or warning anywhere, and code block where just not highlighted (even if "rendered", see image below).

Do you need more info?

from lowlight.

btw, great name haha

<3

Previously this was not throwing any error or warning anywhere, and code block where just not highlighted (even if "rendered", see image below).

I think the difference in behaviour is this line in remark-highlight.js, which switched from highlightAuto to highlight. The behaviour of highlightAuto is to ignore non-existing flags, and that of highlight is to throw. @ben-eb, any reason you opted to switch this?

from lowlight.

Ah, so that's the culprit! Happy to release a patch changing this, no need for a major right?

from lowlight.

No need for a major indeed. Look like it's just a patch :)

from lowlight.

No major, I doubt people are relying on their highlighting to throw. Only case I can imagine for that is tests, but those tests are testing the wrong thing anyhow and should’ve reporter it here already :)

from lowlight.

Thanks!

from lowlight.