Enable some sort of paging or infinite scroll to show all comments. about wordpress-ios HOT 11 CLOSED

Moving to 4.0.1.

from wordpress-ios.

Moving to 4.1.

from wordpress-ios.

@aerych - thoughts on tackling this for an upcoming release?

from wordpress-ios.

Moved to 4.2. There are several things in front of this but we'll get to it.

from wordpress-ios.

@aerych - is this on the radar for 4.2?

from wordpress-ios.

Pushing to 4.3

from wordpress-ios.

Moving to 4.4

from wordpress-ios.

Heya, @koke @astralbodies and @jleandroperez :)

As a part of the solution for this issue I want to simplify our core data schema for comments. AbstractComment and ReaderComment should go away in favor of making Comment the definitive model. I'd really appreciate an early set of eyes on my working branch so I can squash any issues with core data sooner than later.

In particular:

• Dropping AbstractComment and ReaderComment from the schema requires a mapping mapping model to keep core data happy when upgrading. I've created the mapping model and tested upgrading via the simulator. It seems to be working but I'm not sure I haven't missed something important.
• On the Comment model, I've made the blog relationship optional, and changed the post relationship to point to BasePost. Relations do not have to be homogenous and this lets a comment belong to either a Post or ReaderPost model.
• On the CommentService I really was trying to keep the post centric methods more generic but I don't see away around referencing ReaderPost directly. Its probably fine, but I'm open to a different approach.

Thanks guys!

from wordpress-ios.

Less class'ess. Less code, simplier Data Model. +1 Love the idea!

from wordpress-ios.

On the CommentService I really was trying to keep the post centric methods more generic but I don't see away around referencing ReaderPost directly. Its probably fine, but I'm open to a different approach.

I think it's OK as it is, but if you want to, you could extract the merging into a mergeComments:withExistingComments:completionHandler:, then pass either blog.comments or post.comments. Then replace the findComment* methods with findCommentWithID:inExistingComments:

from wordpress-ios.

but if you want to, you could extract the merging

I like that. :) The more generalized the better!

from wordpress-ios.