Giter VIP home page Giter VIP logo

Comments (8)

rwjblue avatar rwjblue commented on June 16, 2024

@Turbo87 - IMHO, it seems fine to support only 2.0 and higher, however we could also just include the polyfill for 1.x support

from ember-qunit-assert-helpers.

Turbo87 avatar Turbo87 commented on June 16, 2024

for reference "the polyfill" is https://github.com/rwjblue/ember-debug-handlers-polyfill

from ember-qunit-assert-helpers.

workmanw avatar workmanw commented on June 16, 2024

We chatted on Slack. I'm closing this in favor of adding a note to the readme about ember-debug-handlers-polyfill.

from ember-qunit-assert-helpers.

Turbo87 avatar Turbo87 commented on June 16, 2024

no, I'm closing this! 😁

from ember-qunit-assert-helpers.

workmanw avatar workmanw commented on June 16, 2024

Hehe. I hit "Comment and close" and it said you had already closed, and no joke I said "Jinx" out loud. 😂

from ember-qunit-assert-helpers.

Turbo87 avatar Turbo87 commented on June 16, 2024

Unfortunately this seems to still be an issue independent from using the polyfill or not

not ok 1 Chrome 62.0 - Global error: Uncaught TypeError: _ember.default.Debug.registerWarnHandler is not a function at http://localhost:7357/assets/test-support.js, line 7468
    ---
        Log: |
            { type: 'error',
              text: 'Uncaught TypeError: _ember.default.Debug.registerWarnHandler is not a function at http://localhost:7357/assets/test-support.js, line 7468\n' }
    ...
not ok 2 Chrome 62.0 - global failure
    ---
        actual: >
            null
        stack: >
            http://localhost:7357/assets/test-support.js:7468
        message: >
            Uncaught TypeError: _ember.default.Debug.registerWarnHandler is not a function
        Log: |
    ...

It appears that the polyfill correctly works for the registerDeprecationHandler() function, but apparently registerWarnHandler() is still missing.

This surfaced in emberjs/ember-map-polyfill#9

/cc @rwjblue

from ember-qunit-assert-helpers.

workmanw avatar workmanw commented on June 16, 2024

I'm open to options here. I don't mind making the addon more durable ... but it could also yield in unexpected behavior for users on 2.0.

@rwjblue would you consider adding registerWarnHandler to ember-debug-handlers-polyfill? I'd happily submit the PR myself.

from ember-qunit-assert-helpers.

rwjblue avatar rwjblue commented on June 16, 2024

Ya, it should have registerWarnHandlers for sure. I'm surprised I forgot it 😢

from ember-qunit-assert-helpers.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.