Incompatible with Ember 2.0 and below about ember-qunit-assert-helpers HOT 8 OPEN

@Turbo87 - IMHO, it seems fine to support only 2.0 and higher, however we could also just include the polyfill for 1.x support

from ember-qunit-assert-helpers.

for reference "the polyfill" is https://github.com/rwjblue/ember-debug-handlers-polyfill

from ember-qunit-assert-helpers.

We chatted on Slack. I'm closing this in favor of adding a note to the readme about ember-debug-handlers-polyfill.

from ember-qunit-assert-helpers.

no, I'm closing this! 😁

from ember-qunit-assert-helpers.

Hehe. I hit "Comment and close" and it said you had already closed, and no joke I said "Jinx" out loud. 😂

from ember-qunit-assert-helpers.

Unfortunately this seems to still be an issue independent from using the polyfill or not

not ok 1 Chrome 62.0 - Global error: Uncaught TypeError: _ember.default.Debug.registerWarnHandler is not a function at http://localhost:7357/assets/test-support.js, line 7468
    ---
        Log: |
            { type: 'error',
              text: 'Uncaught TypeError: _ember.default.Debug.registerWarnHandler is not a function at http://localhost:7357/assets/test-support.js, line 7468\n' }
    ...
not ok 2 Chrome 62.0 - global failure
    ---
        actual: >
            null
        stack: >
            http://localhost:7357/assets/test-support.js:7468
        message: >
            Uncaught TypeError: _ember.default.Debug.registerWarnHandler is not a function
        Log: |
    ...

It appears that the polyfill correctly works for the registerDeprecationHandler() function, but apparently registerWarnHandler() is still missing.

This surfaced in emberjs/ember-map-polyfill#9

/cc @rwjblue

from ember-qunit-assert-helpers.

I'm open to options here. I don't mind making the addon more durable ... but it could also yield in unexpected behavior for users on 2.0.

@rwjblue would you consider adding registerWarnHandler to ember-debug-handlers-polyfill? I'd happily submit the PR myself.

from ember-qunit-assert-helpers.

Ya, it should have registerWarnHandlers for sure. I'm surprised I forgot it 😢

from ember-qunit-assert-helpers.