Giter VIP home page Giter VIP logo

Comments (4)

eiennohito avatar eiennohito commented on June 15, 2024

Names and semantics should be close to Java version as possible.
(comment from Takaoka-san)

from sudachi.rs.

eiennohito avatar eiennohito commented on June 15, 2024

TL:DR

Nice API with multiple sentences is currently blocked in stable Rust by in-progress GATs feature, also see http://lukaskalbertodt.github.io/2018/08/03/solving-the-generalized-streaming-iterator-problem-without-gats.html.

Scratch prototype impl

Want to have:

  • Analyzer having internal mutable state for storing one sentence (and not more) because of performance reasons
  • Iterator over analyzed sentences needs to borrow analyzer mutably to enforce that it is impossible to access the next sentence before consuming the current one

Problems:

  • Current Rust iterators can't borrow from &self without GATs which would probably introduce new-ish Iterator API as well

What to do

  • Provide non-allocating API for
    • Sentence splitting, returning Iterator of &str
    • Provide sentence-based analysis API
  • Optionally provide allocating combined API, which copies needed information (mostly POS) from analyzer
  • Another option would be to implement Iterator-like pattern without using standard library traits to iterate over analyzed sentences (for consuming in while loop).

from sudachi.rs.

eiennohito avatar eiennohito commented on June 15, 2024

Splitting API into sentence splitter / analysis

for sentence in analyzer.split_sentences(line)? {
 let result = analyzer.analyze_sentence(sentence)?
 for token in result.tokens() {
   // process token
 }
}

from sudachi.rs.

eiennohito avatar eiennohito commented on June 15, 2024

Morpheme's part_of_speech should not return option of POS array, it should panic when given invalid POS id instead.

from sudachi.rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.