Giter VIP home page Giter VIP logo

Comments (5)

ankush avatar ankush commented on July 17, 2024

Website looks odd on phone, we need to fix that too

🔜

from repl.

sglavoie avatar sglavoie commented on July 17, 2024

Yes, again it's not that it's more "broken" than before (in fact, I think it's better), but it didn't get fixed either. Still, you came up with the right approach so that's pretty useful in and of itself!

from repl.

sglavoie avatar sglavoie commented on July 17, 2024

So, a single-character fix should have solved this issue 🎉 : 8001fac

It looks much better on mobile too. I didn't do any kind of extensive testing for this of course. Let me know what you think: maybe we will be able to close this issue and #148, although that other one could also live on if we plan on actually improving something at some point 😄.

from repl.

ankush avatar ankush commented on July 17, 2024

Ah. I should've searched for this config before modifying css 🤦

Anyhoo. Checked recent commit. Now it looks MUCH better and far more readable than before. Especially the detail tags. We can close this one, let other one be open so if someone else wants to contribute better design they can propose 😉

from repl.

sglavoie avatar sglavoie commented on July 17, 2024

I should've searched for this config before modifying css

No! in fact that was a useful change that you did and at the same time I saw how CSS was supposed to be modified so I ended up making a little change to the details tag while I was there. Maybe the :hover effect was a bit much, but hey, if it bothers someone else enough, they might just get the necessary motivation to go ahead and fix it by themselves 😁.

from repl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.