Comments (46)
So to sum it up a new angular component will be defined allowing to input several languages.
Definition
The component will basically be an input with a language switch.
The values on the switch are by default english and the UI currently selected language or can be passed as a parameter (required languages).
Validation
When languages are passed as a parameter and all languages are filled, a check will appear on the right of the component.
The form should not be valid until all required languages are filled.
Event data (item name, etc)
A list of required languages should be defined at the event level and passed to all i18n components in the event.
Implementation
An attribute directive would be the most handy for usage.
from worldskills-infrastructure-list.
Sounds good to me. The only thing I would add to that is that when we have a set of required languages we should also allow the addition of other languages. So if French and English are required, we should allow the addition of German and Russian if someone wants to add those too.
from worldskills-infrastructure-list.
Ah I see now. Probably best to remove that link actually.
from worldskills-infrastructure-list.
Okay, I've added/updated the translations on staging. Will be deployed on production with the next deployment (probably next week).
from worldskills-infrastructure-list.
If some fields are not an I18nString
and you think they should be then feel free to refactor them. The example you give would make sense to be an I18nString
For the UI some of our other projects make use of angular-translate
. For example, see https://github.com/worldskills/worldskills-organizations
from worldskills-infrastructure-list.
Yes we are currently working with it to translate WSIL UI.
However that seem to be mainly aimed at translating static content and with some tweaks display translated data (but the API should already allow that without tweaks).
The real question is when an item (example) is created in a given language, where, when, by whom and how will the data be translated ?
A way to do it is to create a dedicated application allowing translators to manage translations for i18n tables from all databases.
What do you think?
from worldskills-infrastructure-list.
I don't think a dedicated application for translating text is the way to go. The text should really be translated in context so that the translator has a full picture of what they are translating. I would prefer to have some type of language switcher on the form. So, for example, the user creates an item, then switches language and uses the same form to enter data for a new language.
@fabian also has some examples from the Events application
from worldskills-infrastructure-list.
Here are some examples how I implemented the translation of the Skill descriptions:
h3. Skill with English as base language
h3. Translations overview
h3. Language translation
Also I don't think it makes sense to have all text fields translatable. E.g. The Required Item description would always be in one language only to avoid communication problems, so no need to change that from String
to I18nString
.
from worldskills-infrastructure-list.
Hi all
ok for Fabian solution
from worldskills-infrastructure-list.
Permissions would also need to be translated
Display in IL:
from worldskills-infrastructure-list.
And also event names
from worldskills-infrastructure-list.
and also categories
from worldskills-infrastructure-list.
and Item status
and quantity unit
NB: Quantity unit could be translated in the front since this seems a static list of values. But since Item status will become configurable for each event, it can only be translated in the DB.
from worldskills-infrastructure-list.
To sum it up, in order to have IL fully translated, we now have to provide a translation UI for:
- item name
- item statuses
- item quantity units
- item category name
- item subcategory name
- event name
- category name
- permissions
- skill name (already implemented)
@worldskills/geeks how do you think we can do that without repeating the very same work each time?
( Having a dedicated application is still an option 😉 )
from worldskills-infrastructure-list.
The ideal would be to have a re-usable angular component that we could drop in whenever we have a translatable piece of text. So it would basically be a text field and a language picker.
from worldskills-infrastructure-list.
Just like @gbervik mentioned, the idea of an angular component seems to be the best option, both for devs and end users.
With @PierreAnctil , we thought of an input component that could handle data translations where needed. We detailed an initial draft of what it could look like into this Google Doc.
Feel free to add comments directly on it if you have any question/suggestion.
from worldskills-infrastructure-list.
I was not sure about the "The form should not be valid until all required languages are filled." part. Maybe some contributors will not be able to translate and then not be able to create items.
It might be more flexible to allow incomplete translations but to display them differently. Maybe a display component which will display the text differently when there are missing translations. Then someone who is actually able to translate will be able to easily see the missing translations.
Or should we start simple and do that later?
from worldskills-infrastructure-list.
That's a good point. I like the flexible option.
from worldskills-infrastructure-list.
Immediate changes:
→ item quantity units
translated in IL front Axiocode
→ item statuses (events) WSI
→ item name (IL) Axiocode
→ item category name (IL) Axiocode
→ item subcategory name (IL) Axiocode
when a user edit a text then the user globally selected language is used as the update target
→ event names
in local language for now
→ categories
→ positions
translated in DB (translations to be sent to @fabian)
The translation component will have to be defined later
from worldskills-infrastructure-list.
French Translations for categories :
General Installations → Installations générales
Workshop Installations → Installations d'atelier
Materials / Consumables → Matériaux / Consommables
Familiarisation materials → Matériaux de familiarisation
Samples → Échantillons
French Translations for positions :
Workshop Sector Manager → Référent de pôle
Workshop Manager → Chef d'atelier
IL Manager → Département technique
@worldskillsfrance Can you please confirm translations?
from worldskills-infrastructure-list.
@PierreAnctil here below my remarques
French Translations for categories :
General Installations → Installations générales
Workshop Installations → Matériels
Materials / Consumables → Matériaux / Consommables
Familiarisation materials → Matériaux de familiarisation (can we mask @gbervik @fabian; if not @PierreAnctil replace by : "Plans"?)
Samples → Échantillons - WSFR-Matériel Prépa Inter
French Translations for positions :
Guest → Visiteurs (@gbervik still can see in positions)
Experts → Experts
Workshop Manager → Chef d'atelier
Skill Competition Manager → Superviseur Technique
Workshop Sector Manager → Référent de pôle
IL Manager → Région Organisatrice « this is rôle « Organizer » in the excel file »
WSFR IL Manager → Admin WSFR (@gbervik still can see in positions)
from worldskills-infrastructure-list.
thanks @worldskillsfrance
@fabian can you please add these translations in the IL database ?
from worldskills-infrastructure-list.
@worldskillsfrance Okay, I've added the translations and the category "Familiarisation materials" is removed from all your lists now.
How important is the translation of the positions for you? Given we will look into cleaning some of the currently confusion around positions and permissions soon, should we wait with those translations to avoid further confusion?
from worldskills-infrastructure-list.
@fabian thx but in staging or in production i still can see "Familiarisation materials"
I made a mistake for one of the category names. Could you change "Échantillons - WSFR-Matériel Prépa Inter" by "WSFR-M2-Matériel Prépa Internationale" (sorry for that)
I also would like to now when someone will clic on "Who-is-who" ?
from worldskills-infrastructure-list.
@fabian thx but in staging or in production i still can see "Familiarisation materials"
Ah yes sorry, only tested the removal locally but forgot to execute it on staging and production. Done now.
I made a mistake for one of the category names. Could you change "Échantillons - WSFR-Matériel Prépa Inter" by "WSFR-M2-Matériel Prépa Internationale" (sorry for that)
No problem. Done.
I also would like to now when someone will clic on "Who-is-who" ?
Sorry, don't understand your question. Click on "Who-is-who" where exactly?
from worldskills-infrastructure-list.
> I also would like to now when someone will clic on "Who-is-who" ?
Sorry, don't understand your question. Click on "Who-is-who" where exactly?
In the oveview of a skills
from worldskills-infrastructure-list.
@gbervik
**1-**Could you we have the same permission in "positions" & "Permissions?
**2-**Could you put all name in french ?
Guest → Visiteurs
Experts → Experts
Workshop Manager → Chef d'atelier
Skill Competition Manager → Superviseur Technique
Workshop Sector Manager → Référent de pôle
IL Manager → Région Organisatrice « this is rôle « Organizer » in the excel file »
WSFR IL Manager → Admin WSFR
from worldskills-infrastructure-list.
@worldskillsfrance there seems to be some confusion about "position" and "permission". A position describes who the person is, and the permission describes what they can do.
The current positions we have for this competition are:
- Workshop Manager (2018)
- Workshop Sector Manager (2018)
- IL Manager (2018)
- Expert
- Skill Competition Manager
These names are all translatable and can have French and English text. I will add the French names for those positions.
We have some collections of permissions called "profiles" which define what users can do in our systems. The profiles for WS France are:
- FR - Admin
- FR - Expert
- FR - Guest
- FR - Organizer
- FR - Sector Manager
- FR - Workshop Manager
These names are not translatable, but they can be changed to French if you like. They will only ever be seen by the person assigning permissions to people.
from worldskills-infrastructure-list.
Yes I understood correctly following your explanations of the last time. I would just like to have the same "architecture/tree" for both (permission & position).
If I talk about that, it's because in the infrastructure lists on the overview tab we see the positions, that's why I want to have the same "architecture/tree" and traduction in french :)
from worldskills-infrastructure-list.
Hello everyone,
I just created a new account on the People platform to test what was going on. I received an email in English and would like to know if we could translate it into French?
On the other hand is it normal that the person does not receive his password, and he must reset?
See photo below.
from worldskills-infrastructure-list.
Hi @worldskillsfrance, we can translate that in to French. If you send me the text I'll add it.
from worldskills-infrastructure-list.
Hi Adam, please find below the french email template
Trame Mail nouveau compte.docx
from worldskills-infrastructure-list.
Hi all,
Could someone delete the text as in the image if after?
Would it be possible to redirect to http://www.worldskills-france.org/ when you click on the WorldSkills logo?
from worldskills-infrastructure-list.
@worldskillsfrance thanks for the translation, but we can't make those emails specific to WorldSkills France. The logins that are created are used for both the WS France IL and all the WS International applications (and also any other Member that uses our software).
The point is that the user just needs the one login to access applications for WS France, WS International, WS Europe or any other WorldSkills event that may use the software, so we will need to make that email text fairly generic.
from worldskills-infrastructure-list.
@worldskills/geeks the item statuses are missing in staging DB
Confirmed → Confirmé
Pending → En attente
Requested → Demandé
Secret → Secret
from worldskills-infrastructure-list.
I would prefer :
Confirmed → Confirmé
Pending → En cours
Requested → A rechercher
Secret → Secret (@fabian can we mask this one ?)
from worldskills-infrastructure-list.
it seemed to me that the language of the infrastructure lists was updated automatically according to the browser. Am I wrong ? (This picture has been made by one user in her first connection)
@PierreAnctil @azanetti could you have a look for that issue please.Thx for you reply
from worldskills-infrastructure-list.
Hi @PierreAnctil ,
When we are here (https://il.worldskills.org/#/event/438/overview) skills overview and when we change language, skills does not change language the other menu yes but not skills.
We need to refresh page. Could you have a look to fix that and make it works as everywhere else.
Thank you
from worldskills-infrastructure-list.
@worldskillsfrance this is already referenced in #51
from worldskills-infrastructure-list.
@PierreAnctil i leave a message to Fabian in Issue 51.
Could you translate that (when we try to delet item in requeste item )
from worldskills-infrastructure-list.
@PierreAnctil
Could you also translate this but and message : (when editing request item, and try to split it)
from worldskills-infrastructure-list.
Could you fix the bug of skills name translation please.
from worldskills-infrastructure-list.
@worldskillsfrance what bug are you talking about? A missing translations? The translation must have been added on the skill meanwhile cause it seems to display correctly in production
from worldskills-infrastructure-list.
Yes im sure, it does not appear everytime but as you can see on the screenshot that i did we have something to do about it.
FYI @ailtisWSFR
from worldskills-infrastructure-list.
@worldskillsfrance do you remember in which scenario it can appear? Or is it completely random?
from worldskills-infrastructure-list.
@PierreAnctil I don't know maybe random.
Did you see my email about a meeting this afternoon ?
from worldskills-infrastructure-list.
Related Issues (20)
- Reconsider "user generated"
- Rethink Skill view
- Potential Supplier HOT 8
- Recommendation for changes or add requested item by experts HOT 12
- Dashboard reports
- Changed translations HOT 2
- Editing Item HOT 3
- New IL manager HOT 3
- Default locale for dates HOT 1
- Add Skill Competition Manager to Skill Management
- Calculated quantity for Supplied Items
- Show Extra details / Comments on Public View HOT 2
- Files in recommendation HOT 4
- Removal of manual sorting HOT 2
- “Recommendations” managing tool slow-down HOT 6
- New table design HOT 1
- Imposibility to delete a Requested Items HOT 4
- Enable inline editing of Supplier in Catalog view
- Make secret a separate field not a status HOT 1
- Recommendations appear multiple times HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from worldskills-infrastructure-list.