Supplier and status per skill about worldskills-infrastructure-list HOT 13 CLOSED

@PierreAnctil Ah yes, we also quickly discussed Potential supplier and we think it makes sense to keep them both to separate between a proposed supplier and the actual supplier.

Also I would name the new tab Supplied Item to avoid confusion.

from worldskills-infrastructure-list.

@PierreAnctil Modifying the supplied item data should not automatically create a new supplied item. If the user explicitly creates a new supplied item with the same name we accept that.

Also note that only users with the right permissions can modify supplied item data.

from worldskills-infrastructure-list.

@worldskills/geeks
According to @worldskillsfrance "Need to add supplier per skill" implies to add all Supplier related fields on skill items:

The way I see it, we should split the skill item edition into 2 tabs.
The first tab will be "General"

and the second one "Host"

We will also change the skill item edition to use a right panel as for the creation.

Are you OK with those changes ?

from worldskills-infrastructure-list.

@worldskillsfrance Maybe the supplier name also need to appear in the skill items list ?

from worldskills-infrastructure-list.

@PierreAnctil I wonder if it makes sense to add all those fields in the database to the table requested_item?

Keep in mind that requested items are an abstract description of what the Skill expects, supplied items then describes the physical item supplied more in detail.

• Supplier: This field already exists, "Potential supplier".

• Supply type: This could make sense in the requested items as a proposal for procurement. However maybe it's better solved with the solution below.

• Unit cost: Not sure what this field means, could be the price that will be paid for the item? This already exists with "Estimated price".

• Unit: Also not really sure what's the idea of this field and confusing in the context with "Unit cost". Could be the unit of the field "Size" (in the tab "General", which is a text field so usually also contains the unit). What is the understanding of @worldskillsfrance for this field and is it even needed at all? @Joni-Aaltonen ?

• PO Number: This is the purchase order number, something that clearly doesn't belong in the requested items. Maybe the following solution would cover it?

One solution would be to allow editing some fields when creating a new supplied item in the Skill item view. So those fields would only show when a new requested item is added and it is not linked to an existing supplied item. Or if the link to an existing supplied item is removed and a new requested item is created for the supplied item (currently not possible but planned).

Using a right panel for editing makes sense.

from worldskills-infrastructure-list.

I just had a quick chat with @worldskillsfrance (Simon) and we discussed the proposed solution of having an editing interface for the supplied item in the Skill view.

This would only show when you have the permissions to edit supplied items but would include Supplier, Supply type, Unit cost, and PO Number. There also needs to be an option to replace the supplied item with a new supplied item in case it has a different supplier or a different reference number. Maybe it would also be helpful to have a list of all other linked requested items from other skills for that supplied items to understand what's being edited.

Also this "editing interface for supplied items" would be visible when adding a new supplied item, even if you don't have permission to edit supplied items (this is effectively already the case, however so far only for the field "name").

While discussing it also became clear for me that the Unit field is related to the field Quantity in requested items, so this field should actually be moved from supplied item to requested item.

from worldskills-infrastructure-list.

@fabian OK thanks for the details.

Did you also agree on the fact that we will have a potential supplier in the General tab and an actual supplier in the Hosts tab?

from worldskills-infrastructure-list.

@fabian @worldskillsfrance If modifying the supplier related data of a requested item creates a new supplied item, we will en up having 2 supplied items with the same name but different data. Is that OK? Or should we force the user to change the item name in this case?

from worldskills-infrastructure-list.

Reopening automatically closed issue.

from worldskills-infrastructure-list.

Hi Fabian, i just end a conversation with Pierre, and i want to be sure about something.
All informations mentioned above are not anymore in the catalogue but on every lines on every skills ?
We have this discution because the issue #8

from worldskills-infrastructure-list.

@worldskillsfrance The information is still stored in the supplied items ("catalogue"), but editing the information is possible (with the right permissions) in the skill as there is an editing interface for the supplied item.

from worldskills-infrastructure-list.

@PierreAnctil As just discussed with Simon, I will work on #22 (Editing of Supplied Item in Requested Item) next to show how the editing of Supplied Items in the Skill view works. We agreed to try this solution and add "shortcut buttons" to help Simon instead of moving the Supplier to the Requested Items.

from worldskills-infrastructure-list.

@fabian could you close this issue ? i think changes are done

from worldskills-infrastructure-list.