Giter VIP home page Giter VIP logo

Comments (27)

PierreAnctil avatar PierreAnctil commented on May 4, 2024 1

@fabian I already checked that and all items have a category on the FR event.

@fabian @ailtisWSFR we reproduced the issue on @lorentzClaude computer. The modal was closing too early and its scope was lost (still cannot figure out why this was working on my end and in staging and in production when @fabian tested though).

We have a fix ready, the PR will come soon.

from worldskills-infrastructure-list.

ailtisWSFR avatar ailtisWSFR commented on May 4, 2024 1

Juste tested the tool now and it does work properly! Thank you very much all! 👍

from worldskills-infrastructure-list.

PierreAnctil avatar PierreAnctil commented on May 4, 2024

@worldskillsfrance I reproduced all your steps in staging and couldn't find a bug:

2018-04-30_13-46-04

When I go to see the requested item in the skill view, everything seems OK as well.

Could you please provide us with details on how to reproduce the bug?

from worldskills-infrastructure-list.

Simon-Woirgard avatar Simon-Woirgard commented on May 4, 2024

@PierreAnctil did you do that test in production ? because when i do that in production it does not work
@fabian did you push all modification that pierre team as made in staging about this issue ?

from worldskills-infrastructure-list.

PierreAnctil avatar PierreAnctil commented on May 4, 2024

@worldskillsfrance That was in staging. I tried the same thing in production and that also worked.

from worldskills-infrastructure-list.

Simon-Woirgard avatar Simon-Woirgard commented on May 4, 2024

I just try and it seems that work some time. But not all the time as you can see below
image

And you also get this in the top of the page :
image

from worldskills-infrastructure-list.

Simon-Woirgard avatar Simon-Woirgard commented on May 4, 2024

I have the problem when there is different statut and i want to put the same statut and name of the potential supplier.

This bug just appear now:
1- i select line with same statut and potential supplier
2- i try to change the statut, and ecrase the name who was written by an other one.
Result :
Statut well change and nothing appear on the potential supplier
image
To change the name, I have to rask again a modification

from worldskills-infrastructure-list.

Simon-Woirgard avatar Simon-Woirgard commented on May 4, 2024

Other Bug :
Before i search all item with Point P written in (potential supplier) and not all was show.
When i do a focus on one skills (carrelage/wall for tilling) i saw some point item i try to modify all (statut and the name of the potential supplier and we get this :
image
image

Some statut are change but not all
Some potential supplier are change but not all
....

from worldskills-infrastructure-list.

PierreAnctil avatar PierreAnctil commented on May 4, 2024

@worldskillsfrance we have reproduced this problem and are working on it

from worldskills-infrastructure-list.

Simon-Woirgard avatar Simon-Woirgard commented on May 4, 2024

ok thx
I think that I am in front of another bug and if this one and truthful it is a very big problem.
I can not be sure because I only see it now and this is the result of work between Saturday and today.

Saturday I started to work on skills and one in particular, put the right things in the right fields and add the "potential supplier".
Today I return to a job in which I worked a lot on Saturday and in potential supplier I see POINT P.
I do not see why I would put this in the field potential supplier. There is really no reason.

I am very afraid that when making multiple changes it does not change the good line.

Could you check that when changing several items it does not change the status or potential supplier of another line?

from worldskills-infrastructure-list.

PierreAnctil avatar PierreAnctil commented on May 4, 2024

@worldskillsfrance I ran some tests and could not reproduce the issue. I also checked the code and it seems reliable. Are you sure that was not a misclick?

from worldskills-infrastructure-list.

Simon-Woirgard avatar Simon-Woirgard commented on May 4, 2024

well can not be sure that there is no miss clic, but it's happen to much time on to much scenarios for a misclick, so yes there is something.

Again, find a new bug appear sometime : Bug when we search item. you can see on the screen shot below :
image

from worldskills-infrastructure-list.

Simon-Woirgard avatar Simon-Woirgard commented on May 4, 2024

Here @PierreAnctil a video of multiple modification who this does not work :
https://www.dropbox.com/s/flbbtsvstfu9fqp/Bug%20request%20modification.mp4?dl=0

from worldskills-infrastructure-list.

PierreAnctil avatar PierreAnctil commented on May 4, 2024

@worldskillsfrance OK thanks, that will help

from worldskills-infrastructure-list.

PierreAnctil avatar PierreAnctil commented on May 4, 2024

@Simon-Woirgard @ailtisWSFR

I tried to reproduce the bug with production data and I still can't (video below might need time to load):

2018-05-23_11-55-10

Do you still encounter this issue?

from worldskills-infrastructure-list.

ailtisWSFR avatar ailtisWSFR commented on May 4, 2024

@PierreAnctil Yes, we still encounter this issue. Just try today with production data and still the same problem, see video linked below :

https://www.dropbox.com/s/fau42cm4il591t5/Mass%20edit%20bug%201.mp4?dl=0

Since we are actually working on the infrastructure list with the host of the event, it becomes urgent to solve this issue.
Thanks in advance.

from worldskills-infrastructure-list.

PierreAnctil avatar PierreAnctil commented on May 4, 2024

@ailtisWSFR can you tell me what your permissions are on https://people.worldskills.org/#/people/person/28347/permissions ?

from worldskills-infrastructure-list.

ailtisWSFR avatar ailtisWSFR commented on May 4, 2024

@PierreAnctil My Position and Permissions :
Position : IL Manager (2018)
Permissions : FR - Admin

And the screenshot of my "Individual permissions for all applications" regarding IL :
image

from worldskills-infrastructure-list.

PierreAnctil avatar PierreAnctil commented on May 4, 2024

@ailtisWSFR
I still cannot reproduce it.
I do not have sufficient permission to test it in production.

Do you have it right after landing on the page? Or do you do something in the page before? Does it always happen? With the same data ?

from worldskills-infrastructure-list.

PierreAnctil avatar PierreAnctil commented on May 4, 2024

@ailtisWSFR
Can you see anything in the developer console?

2018-05-29_17-03-10

from worldskills-infrastructure-list.

PierreAnctil avatar PierreAnctil commented on May 4, 2024

@ailtisWSFR or maybe you can add me the EditItemStatus permission so I can test it? Or @fabian can do it?

from worldskills-infrastructure-list.

ailtisWSFR avatar ailtisWSFR commented on May 4, 2024

@PierreAnctil As shown in the video, I don't do anything more on the page then what is shown in the video.
This problem seems to appear when you have different status applied to the lines that you want to update, but I haven't tried other scenarios.
If @fabian is OK and if it helps, I'm OK too to give you the permission. (but in your video posted 6 days ago with TARKETT, you seemed to already have the correct permission to make the action that I do in my video...)

from worldskills-infrastructure-list.

ailtisWSFR avatar ailtisWSFR commented on May 4, 2024

@PierreAnctil This is what appears on the "Console" :
image

from worldskills-infrastructure-list.

fabian avatar fabian commented on May 4, 2024

@ailtisWSFR I just tried to reproduce the problem on the production environment with your account (I can simulate your user) and didn't get any errors.

@PierreAnctil Could it be that the items didn't have a category yet but have them now?

from worldskills-infrastructure-list.

ailtisWSFR avatar ailtisWSFR commented on May 4, 2024

@fabian @PierreAnctil I'm sorry to let you know that I just tried now and still have the exact same bug...
Is there some kind of time that I need to wait for the fix to be effective in the IL (production)?

from worldskills-infrastructure-list.

fabian avatar fabian commented on May 4, 2024

@ailtisWSFR Sorry, this fix hasn't been pushed to production yet, will do that on Monday. Got closed automatically by the commit comment.

from worldskills-infrastructure-list.

ailtisWSFR avatar ailtisWSFR commented on May 4, 2024

Ok, no problem, thanks for that.

from worldskills-infrastructure-list.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.