Comments (8)
I'm sorry, but SpellPower does not have a definition for 4.3.4.15595 and neither does https://wowdev.wiki/DB/SpellPower. The same goes for TalentTab, which has no definition on here or at https://wowdev.wiki/DB/TalentTab.
I'm not sure what bug you're reporting here. Would you like to share those files you're reporting on, as those appear not to be files from this repository?
from wowdbdefs.
from wowdbdefs.
@bloerwald you might consider reading the title again. There is a branch specifically for client builds prior to WoD:
https://github.com/wowdev/WoWDBDefs/tree/pre-wod
There you find all 4.x definitions and there's where I've dug up my named concerns
from wowdbdefs.
I see, I forgot about that branch. We may want to move this discussion over to the merge request for it.
On TalentTab I fully agree.
On SpellPower it appears to be a result of trying to match the only float value in there. Your observation is right, the powertype column sure isnβt that. I guess we have a column type change across versions?!
from wowdbdefs.
Keep in mind said branch isn't quite up to date or supported/battle-tested like master is.
from wowdbdefs.
@bloerwald I just got a helping hand and received a reversed spell power cost calculation function from the client and I have the answer now. Field 4 and 8 are both PowerCostPct. Field 4 is the fallback field if 8 is 0.f. I guess that's another of these functions that Blizz had implemented halfway for future expansions. So yeah. I guess field 8 is PowerCostPct and field 4 is PowerCostPct2 or other way arround.
@Marlamin I am aware of that. So I think it's a great opportunity to change that now that I had the pleasure to dig through every single field. And as far as I am aware, most of the namings are actually very accurate.
from wowdbdefs.
Hmk, will see if I can properly diff these and merge in any changes manually because it might have diverged a bit too far from master to be easily mergeable the usual way.
from wowdbdefs.
Thank you for looking into this and letting us know.
RE: SpellPower; you are right, they moved from just a numeric field PowerCost
(x/100
) to using PowerCostPct
as a fallback if PowerCost
was 0, to just using PowerCostPct
- full change history is here if anyone is interested.
This has all been merged into master now along with the rest of that branch.
Any PRs and issues are more than welcome for any other changes/fixes!
from wowdbdefs.
Related Issues (20)
- Guessed `ItemSparse.dbd` definition of `2.5.3.4182` HOT 1
- download HOT 1
- Clarification on column annotations HOT 6
- WorldMapOverlay doesn't have a modern definition or no longer exists? HOT 2
- SoundEntries data? HOT 2
- Feedback wanted: Unknown field names HOT 5
- Pre-wod definitions HOT 4
- 8.2.0.30669 Definitions
- Different relationship tables between versions for same columns
- ItemEffect changes [Question]
- DBD v2.0 format discussion HOT 4
- Export to database.xml for WMV HOT 7
- Spell dbc Field_4_0_0_11927_104 --> BonusCoefficient HOT 1
- Wrong Layout for db2 9.0.1 - 9.0.2 ? HOT 3
- ItemSparse.dbd definition error for 2.5.x HOT 5
- ItemSparse.dbd incorrect in 9.1.0.38312 HOT 1
- Help Wanted HOT 2
- Add license HOT 9
- ChrRaces HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wowdbdefs.