Comments (8)
Here's how we do it at PacerPro:
We modified the worker so it returns a Sidekiq::Batch object:
class BatchSearch
include Sidekiq::Worker
def perform(search_id)
@search = Search.find(search_id)
Sidekiq::Batch.new.tap do |batch|
batch.on(:complete, Callback, {'search_id' => search_id})
batch.jobs do
@search.end_points.each do |court|
SearchWorker.perform_async(court.id, @search.id, jid)
end
end
end
end
end
and in RSpec, we call #perform
to run synchronously, then batch.status.join
to run the callbacks and check behavior.
it 'changes the state of the search to "finished"' do
expect {
batch = worker.perform(search.id)
batch.status.join
}.to change { search.reload.status }.from("searching").to("finished")
end
from rspec-sidekiq.
I'm also curious about this. Any suggestions?
from rspec-sidekiq.
from rspec-sidekiq.
I mean, PRs are welcome, but I feel reasonably confident in speaking for the team that we're not going to to spend time working on it if it's a feature that perham thinks is unlikely to work well.
from rspec-sidekiq.
First thanks @kmayer for the job already done.
I have the same problem. From this discussion, Mike Perham say:
I don't support automated testing batches in-process. You can test your worker code, you can test your callback code. You cannot test the entire workflow. People have hacked together solutions but nothing that I want to support long-term.
But I would like to know if rspec-sidekiq plan to add more support for batch callbacks.
from rspec-sidekiq.
Sorry for the bump @kmayer. But I'm still interested ;)
from rspec-sidekiq.
If mike perham is against it we're probably not going to add it.
from rspec-sidekiq.
He said "If anyone comes up with a solution they think is useful to all Sidekiq Pro users, I'm happy to review"
from rspec-sidekiq.
Related Issues (20)
- be_retryable not using global settings HOT 2
- Checking for time has a different format expectation HOT 1
- has_enqueued_sidekiq_job is not matching even though they are identical HOT 7
- Disable all sidekiq jobs for testing HOT 1
- Block syntax `enqueue_sidekiq_job` matcher HOT 8
- Issue with yaml safe loading (psych gem) HOT 2
- `be_delayed` without expected_arguments never matches HOT 4
- RSpec::Sidekiq::NullStatus is missing pending count
- Using ActiveJob::Base with sidekiq_options raises an error HOT 5
- difference in DST handling between Sidekiq's `perform_in` and `have_enqueued_sidekiq_job`
- How to expect to have_enqueued_sidekiq_job with specific queue? - [setting queue name at runtime] HOT 1
- Does this gem need a new owner? HOT 17
- Null Object method missing for Null Batch masks NoMethod errors
- Support Sidekiq 7 and deprecate be_delayed matcher
- Potentially unintentional breaking change in 4.0 with Symbol in argument matchers? HOT 15
- Potentially unintentional breaking change in 4.0.2 with Symbol in argument matchers? (Part 2) HOT 6
- NameError: uninitialized constant RSpec::Matchers::Composable HOT 5
- Match on custom context HOT 1
- feature request: negative matchers HOT 1
- feature suggestion: optional context tag for `sidekiq_retries_exhausted` HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rspec-sidekiq.