Warning about implicit JCR queries triggered by SlingQuery about aem-rules-for-sonarqube HOT 5 CLOSED

Hi Tomek,

I think that's a very good idea to incorporate this as a rule. Will include that into future release.

from aem-rules-for-sonarqube.

I may have found a corner case. It seems that specifying search strategy when looking for parents doesn't change anything, so we may consider making an exception for this case.

However I didn't analyze the code very deeply, it may be worth to look at it.

from aem-rules-for-sonarqube.

Here's an initial unit test. Feel free to add additional cases that you think are common or possible.

https://github.com/Cognifide/AEM-Rules-for-SonarQube/blob/db6df47ec4c46c0b9de8909bbca3dae87cf9abc1/src/test/files/checks/slingquery/SlingQueryImplicitStrategyCheck.java

from aem-rules-for-sonarqube.

@chutch you're quick :)
The test data looks fairly comprehensive.

from aem-rules-for-sonarqube.

@tomaszhulakcogni ideally, we could cover all of the recommendations mentioned here, though that might prove a little complicated.

from aem-rules-for-sonarqube.