Giter VIP home page Giter VIP logo

Comments (4)

Jademhm avatar Jademhm commented on August 25, 2024 2

Here's the feedback:

  • Font size
    • Medium → Body M = 16px
    • Small → Body S = 14px (≠ 16px currently)
  • Underline
    • Not supposed to be 3px but 2px
  • Paddings
    • Font from bottom → 12px for both sizes
    • Currently there’s 16px on Medium and 8px on Small
  • Colour
    • Disabled → I don’t know what the colour is in the inspect, it returns me "rgba(0, 0, 0, 0.55)" which would be Dark 500 in our design records but it’s supposed to be Light 700 (#B3B3B3)

from welcome-ui.

theo-mesnil avatar theo-mesnil commented on August 25, 2024

@Jademhm tu peux tester ici https://feat-tabs--welcome-ui.netlify.app/

from welcome-ui.

Vico4 avatar Vico4 commented on August 25, 2024
  • Disabled → I don’t know what the colour is in the inspect, it returns me "rgba(0, 0, 0, 0.55)" which would be Dark 500 in our design records but it’s supposed to be Light 700 (#B3B3B3)

@Jademhm Light 700 works only on dark theme (it's white with a transparency so it appears white on the doc), is there a light theme color that fits ? Dark 500 was the closest visually that I found.
For everything else I do it today, thank you :)

from welcome-ui.

Jademhm avatar Jademhm commented on August 25, 2024

Default = Dark 700
Disabled = Dark 400

from welcome-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.