Comments (4)
Here's the feedback:
- Font size
- Medium → Body M = 16px
- Small → Body S = 14px (≠ 16px currently)
- Underline
- Not supposed to be 3px but 2px
- Paddings
- Font from bottom → 12px for both sizes
- Currently there’s 16px on Medium and 8px on Small
- Colour
- Disabled → I don’t know what the colour is in the inspect, it returns me "rgba(0, 0, 0, 0.55)" which would be Dark 500 in our design records but it’s supposed to be Light 700 (#B3B3B3)
from welcome-ui.
@Jademhm tu peux tester ici https://feat-tabs--welcome-ui.netlify.app/
from welcome-ui.
- Disabled → I don’t know what the colour is in the inspect, it returns me "rgba(0, 0, 0, 0.55)" which would be Dark 500 in our design records but it’s supposed to be Light 700 (#B3B3B3)
@Jademhm Light 700 works only on dark theme (it's white with a transparency so it appears white on the doc), is there a light theme color that fits ? Dark 500 was the closest visually that I found.
For everything else I do it today, thank you :)
from welcome-ui.
Default = Dark 700
Disabled = Dark 400
from welcome-ui.
Related Issues (20)
- useModalState onClose triggered on mount
- Icon is still in black when I change type of button
- Text properties on Forms
- Popover : triggerMethod hover HOT 1
- DropdownMenu: always hide on click HOT 6
- Tag - remove role listitem on component
- [Infra] Remove Netlify deployment HOT 1
- Date picker
- Label with count
- Drawer not responsive on mobile
- Figma : Select with a long hint
- [TimePicker] the aria live message is always shown HOT 1
- [DatePicker] The forwarded ref isn't forwarded
- Visual Testing
- Misaligned radio on RadioGroup
- [Modal] modal types doesn't use ariakit dialog types HOT 1
- Update Twitter/X icon HOT 2
- Missing (peer)Dependencies HOT 2
- Issue with the icon "thumbs" HOT 2
- [Modal] isn't visible when we update the state during the opening
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from welcome-ui.