Giter VIP home page Giter VIP logo

Comments (5)

fast-90 avatar fast-90 commented on August 27, 2024 1

Fair enough! I have a hacky workaround atm using (when buffer-file-name ...) (as those org-src-edit buffers don't have a file name), but will send an email to the org-mode maillist to ask for their advice.

In any case I'm closing this issue as it is not related to PET. Thanks for the replies, and thanks for this great package which is making my Python package development process a lot easier :)

from emacs-pet.

wyuenho avatar wyuenho commented on August 27, 2024

What's your project layout? Where did you install jupyter? Can you give me a trace of pet-executable-find and/or pet-virtualenv-root?

from emacs-pet.

fast-90 avatar fast-90 commented on August 27, 2024

Thanks for the suggestion to trace those functions! (Sorry still relatively new to Elisp).

See below for the trace. Reading it it seems that the error is caused by the executables it could not find (and therefore returning nil). This makes sense as I do not have those packages (e.g. black) installed in the project venv.

Do you have any suggestions on how to configure pet to avoid running python-pet-hook for org-src blocks? In my normal Python projects I do use these tools, so I would like to keep them in python-pet-hook. I just need them to not search for the executables for my Org notebooks.

I have tried the following without results:

(use-package pet
  :elpaca t
  :hook
  (python-mode . python-pet-hook)
  (org-src-mode. org-src-pet-hook)
  :init
  (defun python-pet-hook ()
    (unless (org-src-edit-buffer-p)
	(pet-mode)))
  (defun org-src-pet-hook ()
    (remove-hook 'python-mode-hook 'python-pet-hook t)))

I have also tried variants with org-in-src-block-p and (bound-and-true-p org-src-mode) without succes. Any suggestions?

Trace
======================================================================
1 -> (pet-executable-find "python")
| 2 -> (pet-virtualenv-root)
| 2 <- pet-virtualenv-root: "/Users/duynguyen/.venv/"
1 <- pet-executable-find: "/Users/duynguyen/.pyenv/versions/3.10.5/bin/python"
======================================================================
1 -> (pet-virtualenv-root)
1 <- pet-virtualenv-root: "/Users/duynguyen/.venv/"
======================================================================
1 -> (pet-executable-find "jedi-language-server")
| 2 -> (pet-virtualenv-root)
| 2 <- pet-virtualenv-root: "/Users/duynguyen/.venv/"
1 <- pet-executable-find: nil
======================================================================
1 -> (pet-executable-find "pytest")
| 2 -> (pet-virtualenv-root)
| 2 <- pet-virtualenv-root: "/Users/duynguyen/.venv/"
1 <- pet-executable-find: nil
======================================================================
1 -> (pet-executable-find "black")
| 2 -> (pet-virtualenv-root)
| 2 <- pet-virtualenv-root: "/Users/duynguyen/.venv/"
1 <- pet-executable-find: nil
======================================================================
1 -> (pet-executable-find "isort")
| 2 -> (pet-virtualenv-root)
| 2 <- pet-virtualenv-root: "/Users/duynguyen/.venv/"
1 <- pet-executable-find: "/Users/duynguyen/.local/bin/isort"
======================================================================
1 -> (pet-executable-find "yapf")
| 2 -> (pet-virtualenv-root)
| 2 <- pet-virtualenv-root: "/Users/duynguyen/.venv/"
1 <- pet-executable-find: "/Users/duynguyen/.local/bin/yapf"

from emacs-pet.

wyuenho avatar wyuenho commented on August 27, 2024

I don't know. I don't use org-mode. AFAIK, similar modes like polymode and markdown-mode have(had) the same problem. This is a problem with how Emacs expose major mode switching lifecycle hooks and how these modes reuse major modes in source code blocks. There's nothing you can do about it at the moment, but perhaps you can file a ticket to Emacs.

from emacs-pet.

wyuenho avatar wyuenho commented on August 27, 2024

Alternatively, you may try to detect whether you are in a project in your hook, and only activate pet mode when you are.

from emacs-pet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.