Comments (3)
frankieroberto
commented on June 19, 2024
Arguably it could be an option passed to the govuk_link_to or govuk_button_to helpers instead? Or we create a new Button component...
Trade-offs between more closely following the govuk-frontend macros vs the Rails conventions...!
from govuk-components.
peteryates
commented on June 19, 2024
I did a quick GitHub search to see if the component was in use anywhere and there are a few - I'll hold off the renaming until the next major version and leave this issue as a reminder.
from govuk-components.
frankieroberto
commented on June 19, 2024
In theory we shouldn't be using the Start now button in services, as it should only be on GOV.UK start pages... ;-)
from govuk-components.
Related Issues (20)
- Support inverse button style HOT 2
- Add task list component HOT 2
- Add inverse option to Breadcrumbs and Back link components
- Support other design systems HOT 1
- `hide_in_print` option won’t work for `nhsuk` brand HOT 3
- Axe updates rejecting the accordion section HOT 3
- SVG attribute `viewBox` not correctly capitalised HOT 1
- Default content for header labels does not match latest version of GOV.UK Frontend
- Version 5 release notes HOT 4
- Bug: undefined method `govuk_visually_hidden' (5.0.0 prerelease)
- Update visually hidden text in action links on summary cards
- Slightly out-of-date gem and node package instructions in the upgrade section of the 5.0.0 release notes HOT 1
- Improvements to `new_tab` behaviour HOT 2
- Default title for govuk_tabs
- Update breadcrumbs to accept an array, deprecate hash argument HOT 2
- Lists HOT 6
- Previews for Components HOT 2
- Add `data-module="govuk-button"` to links styled as buttons HOT 1
- Gem can generate invalid duplicate data attributes on buttons
- Notification banner: with_heading can't generate heading tags HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from govuk-components.