Giter VIP home page Giter VIP logo

Comments (4)

tijmenb avatar tijmenb commented on June 16, 2024 2

I think GOVUK might be too generic, when I was on GOV.UK we tried to avoid it because of the risk of collisions with internal & external libraries (compounded by problems with Govuk vs GOVUK and Rails inflection).

To the suffix question, I think -Component is indeed noise if we have a namespace, so perhaps this works:

GovukComponent::Panel.new
GovukComponent::Tag.new
GovukComponent::StartNowButton.new

from govuk-components.

tvararu avatar tvararu commented on June 16, 2024

I like separating components by directory; I'd argue for colocating (unit) specs next to components as well.

πŸ‘ for GOVUK::StartNowButtonComponent

from govuk-components.

peteryates avatar peteryates commented on June 16, 2024

I've submitted #5 and it feels like the the right approach. I can't see a way of keeping the names simple and predictable and organising with one component per directory.

Leaving the task unchecked in case I've missed something obvious.

from govuk-components.

peteryates avatar peteryates commented on June 16, 2024

Merged #5, I like this approach apart from the previously stated reasons (multiple components in one directory, the weird capitalisation of Govuk 😞).

Everything else is better though, so until something better comes along let's go with it

from govuk-components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.