Comments (4)
I think GOVUK
might be too generic, when I was on GOV.UK we tried to avoid it because of the risk of collisions with internal & external libraries (compounded by problems with Govuk
vs GOVUK
and Rails inflection).
To the suffix question, I think -Component
is indeed noise if we have a namespace, so perhaps this works:
GovukComponent::Panel.new
GovukComponent::Tag.new
GovukComponent::StartNowButton.new
from govuk-components.
I like separating components by directory; I'd argue for colocating (unit) specs next to components as well.
π for GOVUK::StartNowButtonComponent
from govuk-components.
I've submitted #5 and it feels like the the right approach. I can't see a way of keeping the names simple and predictable and organising with one component per directory.
Leaving the task unchecked in case I've missed something obvious.
from govuk-components.
Merged #5, I like this approach apart from the previously stated reasons (multiple components in one directory, the weird capitalisation of Govuk
π).
Everything else is better though, so until something better comes along let's go with it
from govuk-components.
Related Issues (20)
- Support inverse button style HOT 2
- Add task list component HOT 2
- Add inverse option to Breadcrumbs and Back link components
- Support other design systems HOT 1
- `hide_in_print` option wonβt work for `nhsuk` brand HOT 3
- Axe updates rejecting the accordion section HOT 3
- SVG attribute `viewBox` not correctly capitalised HOT 1
- Default content for header labels does not match latest version of GOV.UK Frontend
- Version 5 release notes HOT 4
- Bug: undefined method `govuk_visually_hidden' (5.0.0 prerelease)
- Update visually hidden text in action links on summary cards
- Slightly out-of-date gem and node package instructions in the upgrade section of the 5.0.0 release notes HOT 1
- Improvements to `new_tab` behaviour HOT 2
- Default title for govuk_tabs
- Update breadcrumbs to accept an array, deprecate hash argument HOT 2
- Lists HOT 6
- Previews for Components HOT 2
- Add `data-module="govuk-button"` to links styled as buttons HOT 1
- Gem can generate invalid duplicate data attributes on buttons
- Notification banner: with_heading can't generate heading tags HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from govuk-components.