Giter VIP home page Giter VIP logo

Comments (3)

peteryates avatar peteryates commented on July 4, 2024

Just tried doing this with the Nunjucks macros and it looks a bit weird with multiple actions. I amended the code from the first example on the summary list page by adding 'Remove' and 'Confirm':

{{ govukSummaryList({
  rows: [
    {
      key: {
        text: "Name"
      },
      value: {
        text: "Sarah Philips"
      },
      actions: {
        items: [
          {
            href: "/change",
            text: "Change"
          },
          {
            href: "/remove",
            text: "Remove"
          },
          {
            href: "/confirm",
            text: "Confirm"
          }
        ]
      }
    },
    // ✂️ 
  ]
}) }}

The output definitely looks wrong.

Screenshot from 2021-07-25 14-08-12

I'm either calling it incorrectly or there's an underlying bug. I'll go ahead and implement the component regardless and keep in mind it might need adjusting prior to merge.

from govuk-components.

paulrobertlloyd avatar paulrobertlloyd commented on July 4, 2024

Interesting. That certainly looks like a bug. I can file an issue on the design system repo, but it does demonstrate that multiple actions is an intentional part of the component, given the separators between each link. Probably not spotted before because it's not often a row has multiple actions associated with it (or the labels are very short when they do).

from govuk-components.

peteryates avatar peteryates commented on July 4, 2024

Fixed by #222

from govuk-components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.